Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2544003003: Revert of Introduce a separate FunctionLiteral ID for Eval (Closed)

Created:
4 years ago by jochen (gone - plz use gerrit)
Modified:
4 years ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Introduce a separate FunctionLiteral ID for Eval (patchset #1 id:1 of https://codereview.chromium.org/2533303006/ ) Reason for revert: My assumption that eval and top-level code should be handled differently was wrong Original issue's description: > Introduce a separate FunctionLiteral ID for Eval > > Top level SharedFunctionInfos will end up in a scripts SFI list, but > eval'd SFIs shouldn't. Separate IDs will allow for adding a > corresponding DCHECK. > > BUG=v8:5589 > R=marja@chromium.org > > Committed: https://crrev.com/c6d421ff9aee7f3cab9e48faac88f6b08d2f1cf5 > Cr-Commit-Position: refs/heads/master@{#41421} TBR=marja@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5589 Committed: https://crrev.com/13afe427052768703f691051800ce4d48ce5df99 Cr-Commit-Position: refs/heads/master@{#41448}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M src/ast/ast.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/parsing/parser.cc View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
jochen (gone - plz use gerrit)
Created Revert of Introduce a separate FunctionLiteral ID for Eval
4 years ago (2016-12-02 10:01:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2544003003/1
4 years ago (2016-12-02 10:02:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 10:02:12 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-02 10:02:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/13afe427052768703f691051800ce4d48ce5df99
Cr-Commit-Position: refs/heads/master@{#41448}

Powered by Google App Engine
This is Rietveld 408576698