Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2543953002: gn: Make arm_arch configurable (Closed)

Created:
4 years ago by hashimoto
Modified:
4 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Make arm_arch configurable Chrome OS needs to use values like armv7ve and armv8-a+crc. BUG=670242 Committed: https://crrev.com/99cae1ee0ee6c49c0c3d276dbbb8a271d9a03bb4 Cr-Commit-Position: refs/heads/master@{#435867}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M build/config/arm.gni View 4 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
hashimoto
4 years ago (2016-12-01 10:05:40 UTC) #4
Dirk Pranke
lgtm
4 years ago (2016-12-01 20:54:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2543953002/1
4 years ago (2016-12-02 06:11:04 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 06:15:51 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-02 06:18:43 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99cae1ee0ee6c49c0c3d276dbbb8a271d9a03bb4
Cr-Commit-Position: refs/heads/master@{#435867}

Powered by Google App Engine
This is Rietveld 408576698