Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 254393008: Enabling new-style 'virtual viewport' pinch by default on ChromeOS (Closed)

Created:
6 years, 8 months ago by bokan
Modified:
6 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, wjmaclean, aelias_OOO_until_Jul13, kevers
Visibility:
Public.

Description

Enabling new-style 'virtual viewport' pinch by default on ChromeOS ChromeOS virtual keyboard depends on the virtual viewport to support overscrolling. Enabled it by default on ChromeOS and removed it as an experiment from about:flags. Also added the experiment to Android since we'll eventually want to enable it there too. BUG=366670 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266119

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M chrome/browser/about_flags.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
bokan
sky@, PTAL. Thanks.
6 years, 8 months ago (2014-04-24 15:41:32 UTC) #1
sky
LGTM
6 years, 8 months ago (2014-04-24 16:29:44 UTC) #2
bokan
The CQ bit was checked by bokan@chromium.org
6 years, 8 months ago (2014-04-24 18:28:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bokan@chromium.org/254393008/1
6 years, 8 months ago (2014-04-24 21:52:24 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 22:39:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-24 22:39:54 UTC) #6
bokan
The CQ bit was checked by bokan@chromium.org
6 years, 8 months ago (2014-04-24 22:49:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bokan@chromium.org/254393008/20001
6 years, 8 months ago (2014-04-24 22:51:59 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 03:30:31 UTC) #9
Message was sent while issue was closed.
Change committed as 266119

Powered by Google App Engine
This is Rietveld 408576698