Issue 254393004: LocationBarView should consistently NULL-check GetWebContents().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 254393004: LocationBarView should consistently NULL-check GetWebContents(). (Closed)

Created:
6 years, 8 months ago by Peter Kasting

Modified:
6 years, 8 months ago

Reviewers:
Greg Billock

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

LocationBarView should consistently NULL-check GetWebContents(). This also makes us consistently use GetWebContents() (instead of delegate_->GetWebContents()) and, if it's to be stored in a variable, names the variable |web_contents| (which is what the majority of uses already did). BUG=362645 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266046

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -16 lines)			Patch
	M	chrome/browser/ui/views/location_bar/location_bar_view.cc	View		9 chunks	+17 lines, -16 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkasting@chromium.org/254393004/1

6 years, 8 months ago (2014-04-24 21:16:50 UTC) #4

Message was sent while issue was closed.

Change committed as 266046

Expand Messages | Collapse Messages