Add systemwide session file for Chromoting

Add systemwide session file for Chromoting

This adds /etc/chrome-remote-desktop-session to the list of files that
the script looks for when deciding what session to start.

BUG=366759
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266613

[Lambros, 2014-04-23 22:28:00]

This seems a reasonable feature to add. For various reasons, a system
administrator might want to configure a default Chromoting session that is
different from the system's default console session.

[Sergey Ulanov, 2014-04-23 22:41:51]

https://codereview.chromium.org/254393003/diff/1/remoting/host/linux/linux_me...
File remoting/host/linux/linux_me2me_host.py (right):

https://codereview.chromium.org/254393003/diff/1/remoting/host/linux/linux_me...
remoting/host/linux/linux_me2me_host.py:542: SYSTEM_SESSION_FILE_PATH ]
Maybe put this above .xsession? (it has higher change of working properly)

[Lambros, 2014-04-23 23:04:13]

https://codereview.chromium.org/254393003/diff/1/remoting/host/linux/linux_me...
File remoting/host/linux/linux_me2me_host.py (right):

https://codereview.chromium.org/254393003/diff/1/remoting/host/linux/linux_me...
remoting/host/linux/linux_me2me_host.py:542: SYSTEM_SESSION_FILE_PATH ]
On 2014/04/23 22:41:52, Sergey Ulanov wrote:
> Maybe put this above .xsession? (it has higher change of working properly)

I'd like to get rid of .xsession completely. Modern Linux distros don't use
these files any more, so these files are typically remnants from older systems
and often don't work properly when people set up Chromoting for the first time.
WDYT?

[Sergey Ulanov, 2014-04-24 00:10:21]

https://codereview.chromium.org/254393003/diff/1/remoting/host/linux/linux_me...
File remoting/host/linux/linux_me2me_host.py (right):

https://codereview.chromium.org/254393003/diff/1/remoting/host/linux/linux_me...
remoting/host/linux/linux_me2me_host.py:542: SYSTEM_SESSION_FILE_PATH ]
On 2014/04/23 23:04:13, Lambros wrote:
> On 2014/04/23 22:41:52, Sergey Ulanov wrote:
> > Maybe put this above .xsession? (it has higher change of working properly)
> 
> I'd like to get rid of .xsession completely. Modern Linux distros don't use
> these files any more, so these files are typically remnants from older systems
> and often don't work properly when people set up Chromoting for the first
time.
> WDYT?

sgtm

[Sergey Ulanov, 2014-04-24 01:11:10]

Also please remove BUG= or remove a separate bug. 353710 is unrelated.

[Lambros, 2014-04-24 20:27:52]

Also updated BUG= number and added NOTRY=true.

https://codereview.chromium.org/254393003/diff/1/remoting/host/linux/linux_me...
File remoting/host/linux/linux_me2me_host.py (right):

https://codereview.chromium.org/254393003/diff/1/remoting/host/linux/linux_me...
remoting/host/linux/linux_me2me_host.py:542: SYSTEM_SESSION_FILE_PATH ]
On 2014/04/24 00:10:21, Sergey Ulanov wrote:
> On 2014/04/23 23:04:13, Lambros wrote:
> > On 2014/04/23 22:41:52, Sergey Ulanov wrote:
> > > Maybe put this above .xsession? (it has higher change of working properly)
> > 
> > I'd like to get rid of .xsession completely. Modern Linux distros don't use
> > these files any more, so these files are typically remnants from older
systems
> > and often don't work properly when people set up Chromoting for the first
> time.
> > WDYT?
> 
> sgtm

Done.

https://codereview.chromium.org/254393003/diff/20001/remoting/host/linux/linu...
File remoting/host/linux/linux_me2me_host.py (left):

https://codereview.chromium.org/254393003/diff/20001/remoting/host/linux/linu...
remoting/host/linux/linux_me2me_host.py:535: # session instead of looking for
custom .xsession files in the home directory.
Don't think this comment makes much sense any more. Modern display-managers
don't check .xsession, so we shouldn't do it either.

[Sergey Ulanov, 2014-04-26 00:36:31]

lgtm

https://codereview.chromium.org/254393003/diff/20001/remoting/host/linux/linu...
File remoting/host/linux/linux_me2me_host.py (right):

https://codereview.chromium.org/254393003/diff/20001/remoting/host/linux/linu...
remoting/host/linux/linux_me2me_host.py:84: if os.path.isdir(CONFIG_DIR) or
os.path.isfile(SESSION_FILE_PATH):
maybe add a check for SYSTEM_SESSION_FILE_PATH here too.

[Lambros, 2014-04-28 18:47:58]

https://codereview.chromium.org/254393003/diff/20001/remoting/host/linux/linu...
File remoting/host/linux/linux_me2me_host.py (right):

https://codereview.chromium.org/254393003/diff/20001/remoting/host/linux/linu...
remoting/host/linux/linux_me2me_host.py:84: if os.path.isdir(CONFIG_DIR) or
os.path.isfile(SESSION_FILE_PATH):
On 2014/04/26 00:36:31, Sergey Ulanov wrote:
> maybe add a check for SYSTEM_SESSION_FILE_PATH here too.

Done.

[Lambros, 2014-04-28 18:48:02]

The CQ bit was checked by lambroslambrou@chromium.org

[commit-bot: I haz the power, 2014-04-28 18:48:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/254393003/...

[commit-bot: I haz the power, 2014-04-28 18:49:20]

Change committed as 266613