third_party/WebKit/LayoutTests/compositing/contents-opaque/hidden-with-visible-text.html - Issue 2543913002: Generalize visible descendant dirty bits to prepare for more properties.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/compositing/contents-opaque/hidden-with-visible-text.html

Issue 2543913002: Generalize visible descendant dirty bits to prepare for more properties. (Closed)

Patch Set: none Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/compositing/contents-opaque/hidden-with-visible-text-expected.txt » ('j') | third_party/WebKit/LayoutTests/compositing/contents-opaque/hidden-with-visible-text-expected.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <style>	4 <style>

5 #caption {	5 #caption {

6 width: 200px;	6 width: 200px;

7 height: 100px;	7 height: 100px;

8 background-color: green;	8 background-color: green;

9 transform: translateZ(0);	9 transform: translateZ(0);

10 }	10 }

11 .inner {	11 .inner {

12 visibility: visible;	12 visibility: visible;

13 background-color: blue;	13 background-color: blue;

14 }	14 }

15 </style>	15 </style>

16 <script type="text/javascript">	16 <script type="text/javascript">

17 if (window.testRunner)	17 if (window.testRunner)

18 testRunner.dumpAsText();	18 testRunner.dumpAsText();

19	19

20 function doTest() {	20 function doTest() {

21 document.getElementById("caption").style.visibility = "hidden";	21 document.getElementById("caption").style.visibility = "hidden";

22 if (window.testRunner && window.internals)	22 if (window.testRunner && window.internals)

23 document.getElementById('layertree').innerText = window.internal s.layerTreeAsText(document);	23 document.getElementById('layertree').innerText = window.internal s.layerTreeAsText(document);

24 }	24 }

25 window.addEventListener('load', doTest, false);	25 window.addEventListener('load', doTest, false);

26 </script>	26 </script>

27 </head>	27 </head>

28 <body>	28 <body>

29 <div id="caption" style="position: fixed; background: green;">Caption</div>	29 <div id="caption" style="position: fixed; background: green;">

	30 <span class="inner">Caption</span></div>
	chrishtr 2016/12/01 16:13:37 My CL actually fixes this test, as it was previous My CL actually fixes this test, as it was previously written. See: https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_r... The "caption" composited layer should not be present, because it's entirely invisible. I verified this by, at ToT, putting visibility: hidden on the "caption" element via inline style (vs modifying with script), and as expected the composited layer disappears from the output. The old code failed to invalidate the visibility status when adding visibility: hidden to the "caption" element. However, the test as named is intended to check that there is still a composited layer if there is visible text below an invisible element. It was added here: https://codereview.chromium.org/15925012 by copying two WebKit tests added here: http://trac.webkit.org/changeset/149084 The test in WebKit was wrong in the first place, because there is no element with class "inner" in the page. So I added it to the test here, and rebaselined.
30 <pre id="layertree"></pre>	31 <pre id="layertree"></pre>

31 </body>	32 </body>

32 </html>	33 </html>

OLD	NEW