Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 2543913002: Generalize visible descendant dirty bits to prepare for more properties. (Closed)
Patch Set: none Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc.
7 * All rights reserved. 7 * All rights reserved.
8 * Copyright (C) 2009 Google Inc. All rights reserved. 8 * Copyright (C) 2009 Google Inc. All rights reserved.
9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. 9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
10 * (http://www.torchmobile.com/) 10 * (http://www.torchmobile.com/)
(...skipping 1735 matching lines...) Expand 10 before | Expand all | Expand 10 after
1746 document().setAnnotatedRegionsDirty(true); 1746 document().setAnnotatedRegionsDirty(true);
1747 if (AXObjectCache* cache = document().existingAXObjectCache()) 1747 if (AXObjectCache* cache = document().existingAXObjectCache())
1748 cache->childrenChanged(parent()); 1748 cache->childrenChanged(parent());
1749 } 1749 }
1750 1750
1751 // Keep layer hierarchy visibility bits up to date if visibility changes. 1751 // Keep layer hierarchy visibility bits up to date if visibility changes.
1752 if (m_style->visibility() != newStyle.visibility()) { 1752 if (m_style->visibility() != newStyle.visibility()) {
1753 // We might not have an enclosing layer yet because we might not be in the 1753 // We might not have an enclosing layer yet because we might not be in the
1754 // tree. 1754 // tree.
1755 if (PaintLayer* layer = enclosingLayer()) 1755 if (PaintLayer* layer = enclosingLayer())
1756 layer->potentiallyDirtyVisibleContentStatus(newStyle.visibility()); 1756 layer->dirtyVisibleContentStatus();
1757 } 1757 }
1758 1758
1759 if (isFloating() && (m_style->floating() != newStyle.floating())) { 1759 if (isFloating() && (m_style->floating() != newStyle.floating())) {
1760 // For changes in float styles, we need to conceivably remove ourselves 1760 // For changes in float styles, we need to conceivably remove ourselves
1761 // from the floating objects list. 1761 // from the floating objects list.
1762 toLayoutBox(this)->removeFloatingOrPositionedChildFromBlockLists(); 1762 toLayoutBox(this)->removeFloatingOrPositionedChildFromBlockLists();
1763 } else if (isOutOfFlowPositioned() && 1763 } else if (isOutOfFlowPositioned() &&
1764 (m_style->position() != newStyle.position())) { 1764 (m_style->position() != newStyle.position())) {
1765 // For changes in positioning styles, we need to conceivably remove 1765 // For changes in positioning styles, we need to conceivably remove
1766 // ourselves from the positioned objects list. 1766 // ourselves from the positioned objects list.
(...skipping 1735 matching lines...) Expand 10 before | Expand all | Expand 10 after
3502 const blink::LayoutObject* root = object1; 3502 const blink::LayoutObject* root = object1;
3503 while (root->parent()) 3503 while (root->parent())
3504 root = root->parent(); 3504 root = root->parent();
3505 root->showLayoutTreeAndMark(object1, "*", object2, "-", 0); 3505 root->showLayoutTreeAndMark(object1, "*", object2, "-", 0);
3506 } else { 3506 } else {
3507 WTFLogAlways("%s", "Cannot showLayoutTree. Root is (nil)"); 3507 WTFLogAlways("%s", "Cannot showLayoutTree. Root is (nil)");
3508 } 3508 }
3509 } 3509 }
3510 3510
3511 #endif 3511 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698