|
|
Created:
4 years ago by ghost stip (do not use) Modified:
4 years ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd documentation to the testing/buildbot directory.
BUG=663077
Committed: https://crrev.com/0ddda28cc596b25ce619d764e7bfec73e7e46ee4
Cr-Commit-Position: refs/heads/master@{#435734}
Patch Set 1 #
Total comments: 7
Patch Set 2 : Fixups, address comments. #
Total comments: 1
Messages
Total messages: 16 (7 generated)
Description was changed from ========== Add documentation to the testing/buildbot directory. BUG=663077 ========== to ========== Add documentation to the testing/buildbot directory. BUG=663077 ==========
stip@chromium.org changed reviewers: + agable@chromium.org, katthomas@chromium.org
ptal
Make sure you run https://cs.chromium.org/chromium/src/tools/md_browser/README.md to ensure this renders correctly. https://codereview.chromium.org/2543883002/diff/1/testing/buildbot/README.md File testing/buildbot/README.md (right): https://codereview.chromium.org/2543883002/diff/1/testing/buildbot/README.md#... testing/buildbot/README.md:34: [a6e11220](https://chromium.googlesource.com/chromium/tools/build/+/a6e11220d97d578d6ba091abd68beba28a004722) ...4722), https://codereview.chromium.org/2543883002/diff/1/testing/buildbot/README.md#... testing/buildbot/README.md:40: ## How to edit ### Making the changes #### Buildbot configuration json After Looks like these got accidentally hoisted onto the same line https://codereview.chromium.org/2543883002/diff/1/testing/buildbot/README.md#... testing/buildbot/README.md:41: editing any buildbot json, run ``./manage.py -w`` to load and write in the I think you only need single backticks https://codereview.chromium.org/2543883002/diff/1/testing/buildbot/README.md#... testing/buildbot/README.md:53: ### Trying the changes on trybots You should be able to try build changes that Some hoisting here too https://codereview.chromium.org/2543883002/diff/1/testing/buildbot/README.md#... testing/buildbot/README.md:58: ## Capacity considerations when editing the buildbot configuration json When And here
viewed in the reader, checks out https://codereview.chromium.org/2543883002/diff/1/testing/buildbot/README.md File testing/buildbot/README.md (right): https://codereview.chromium.org/2543883002/diff/1/testing/buildbot/README.md#... testing/buildbot/README.md:34: [a6e11220](https://chromium.googlesource.com/chromium/tools/build/+/a6e11220d97d578d6ba091abd68beba28a004722) On 2016/12/01 01:31:54, agable wrote: > ...4722), ish, but sure https://codereview.chromium.org/2543883002/diff/1/testing/buildbot/README.md#... testing/buildbot/README.md:40: ## How to edit ### Making the changes #### Buildbot configuration json After On 2016/12/01 01:31:54, agable wrote: > Looks like these got accidentally hoisted onto the same line ugh, vim's "gq" isn't markdown aware and I thought I got most of the weird joins
https://codereview.chromium.org/2543883002/diff/20001/testing/buildbot/README.md File testing/buildbot/README.md (right): https://codereview.chromium.org/2543883002/diff/20001/testing/buildbot/README... testing/buildbot/README.md:9: * <master_name\>.json -- buildbot configuration json files. These are used to don't ask me why < should be unescaped but > can't be.
lgtm
katthomas@google.com changed reviewers: + katthomas@google.com
lgtm too This is great. Thanks stip!
The CQ bit was checked by stip@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480626575265140, "parent_rev": "18a8641e22bf394398e91fe486a330b7ce90c174", "commit_rev": "51539b12a9c15aa60dd8d484510214baa2cda298"}
Message was sent while issue was closed.
Description was changed from ========== Add documentation to the testing/buildbot directory. BUG=663077 ========== to ========== Add documentation to the testing/buildbot directory. BUG=663077 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add documentation to the testing/buildbot directory. BUG=663077 ========== to ========== Add documentation to the testing/buildbot directory. BUG=663077 Committed: https://crrev.com/0ddda28cc596b25ce619d764e7bfec73e7e46ee4 Cr-Commit-Position: refs/heads/master@{#435734} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/0ddda28cc596b25ce619d764e7bfec73e7e46ee4 Cr-Commit-Position: refs/heads/master@{#435734} |