Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2543883002: Add documentation to the testing/buildbot directory. (Closed)

Created:
4 years ago by ghost stip (do not use)
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add documentation to the testing/buildbot directory. BUG=663077 Committed: https://crrev.com/0ddda28cc596b25ce619d764e7bfec73e7e46ee4 Cr-Commit-Position: refs/heads/master@{#435734}

Patch Set 1 #

Total comments: 7

Patch Set 2 : Fixups, address comments. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -0 lines) Patch
A testing/buildbot/README.md View 1 1 chunk +67 lines, -0 lines 1 comment Download

Messages

Total messages: 16 (7 generated)
ghost stip (do not use)
ptal
4 years ago (2016-12-01 01:08:39 UTC) #3
agable
Make sure you run https://cs.chromium.org/chromium/src/tools/md_browser/README.md to ensure this renders correctly. https://codereview.chromium.org/2543883002/diff/1/testing/buildbot/README.md File testing/buildbot/README.md (right): https://codereview.chromium.org/2543883002/diff/1/testing/buildbot/README.md#newcode34 ...
4 years ago (2016-12-01 01:31:54 UTC) #4
ghost stip (do not use)
viewed in the reader, checks out https://codereview.chromium.org/2543883002/diff/1/testing/buildbot/README.md File testing/buildbot/README.md (right): https://codereview.chromium.org/2543883002/diff/1/testing/buildbot/README.md#newcode34 testing/buildbot/README.md:34: [a6e11220](https://chromium.googlesource.com/chromium/tools/build/+/a6e11220d97d578d6ba091abd68beba28a004722) On 2016/12/01 ...
4 years ago (2016-12-01 02:26:51 UTC) #5
ghost stip (do not use)
https://codereview.chromium.org/2543883002/diff/20001/testing/buildbot/README.md File testing/buildbot/README.md (right): https://codereview.chromium.org/2543883002/diff/20001/testing/buildbot/README.md#newcode9 testing/buildbot/README.md:9: * <master_name\>.json -- buildbot configuration json files. These are ...
4 years ago (2016-12-01 02:27:57 UTC) #6
agable
lgtm
4 years ago (2016-12-01 17:09:09 UTC) #7
katthomas
lgtm too This is great. Thanks stip!
4 years ago (2016-12-01 18:37:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2543883002/20001
4 years ago (2016-12-01 21:10:18 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-01 22:07:41 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-01 22:11:40 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0ddda28cc596b25ce619d764e7bfec73e7e46ee4
Cr-Commit-Position: refs/heads/master@{#435734}

Powered by Google App Engine
This is Rietveld 408576698