[stubs] Use CSA::IsHeapNumberMap() instead of manual map comparing.

src/builtins/builtins-array.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/builtins/builtins.h"
 #include "src/builtins/builtins-utils.h"
 
 #include "src/code-factory.h"
 #include "src/contexts.h"
 #include "src/elements.h"
@@ skipping 1405 matching lines @@
   Node* array = assembler.Parameter(0);
   Node* search_element = assembler.Parameter(1);
   Node* start_from = assembler.Parameter(2);
   Node* context = assembler.Parameter(3 + 2);
 
   Node* intptr_zero = assembler.IntPtrConstant(0);
   Node* intptr_one = assembler.IntPtrConstant(1);
 
   Node* the_hole = assembler.TheHoleConstant();
   Node* undefined = assembler.UndefinedConstant();
-  Node* heap_number_map = assembler.HeapNumberMapConstant();
 
   Variable len_var(&assembler, MachineType::PointerRepresentation()),
       index_var(&assembler, MachineType::PointerRepresentation()),
       start_from_var(&assembler, MachineType::PointerRepresentation());
 
   Label init_k(&assembler), return_true(&assembler), return_false(&assembler),
       call_runtime(&assembler);
 
   Label init_len(&assembler);
 
@@ skipping 110 matching lines @@
         not_heap_num(&assembler);
 
     assembler.GotoUnless(assembler.TaggedIsSmi(search_element), &not_smi);
     search_num.Bind(assembler.SmiToFloat64(search_element));
     assembler.Goto(&heap_num_loop);
 
     assembler.Bind(&not_smi);
     assembler.GotoIf(assembler.WordEqual(search_element, undefined),
                      &undef_loop);
     Node* map = assembler.LoadMap(search_element);
-    assembler.GotoIf(assembler.WordNotEqual(map, heap_number_map),
-                     &not_heap_num);
+    assembler.GotoUnless(assembler.IsHeapNumberMap(map), &not_heap_num);
     search_num.Bind(assembler.LoadHeapNumberValue(search_element));
     assembler.Goto(&heap_num_loop);
 
     assembler.Bind(&not_heap_num);
     Node* search_type = assembler.LoadMapInstanceType(map);
     assembler.GotoIf(assembler.IsStringInstanceType(search_type), &string_loop);
     assembler.GotoIf(
         assembler.Word32Equal(search_type,
                               assembler.Int32Constant(SIMD128_VALUE_TYPE)),
         &simd_loop);
@@ skipping 43 matching lines @@
         Node* element_k = assembler.LoadFixedArrayElement(
             elements, index_var.value(), 0,
             CodeStubAssembler::INTPTR_PARAMETERS);
         assembler.GotoUnless(assembler.TaggedIsSmi(element_k), &not_smi);
         assembler.Branch(
             assembler.Float64Equal(search_num.value(),
                                    assembler.SmiToFloat64(element_k)),
             &return_true, &continue_loop);
 
         assembler.Bind(&not_smi);
-        assembler.GotoIf(assembler.WordNotEqual(assembler.LoadMap(element_k),
-                                                heap_number_map),
-                         &continue_loop);
+        assembler.GotoUnless(
+            assembler.IsHeapNumberMap(assembler.LoadMap(element_k)),
+            &continue_loop);
         assembler.Branch(
             assembler.Float64Equal(search_num.value(),
                                    assembler.LoadHeapNumberValue(element_k)),
             &return_true, &continue_loop);
 
         assembler.Bind(&continue_loop);
         index_var.Bind(assembler.IntPtrAdd(index_var.value(), intptr_one));
         assembler.Goto(&not_nan_loop);
       }
 
       assembler.Bind(&nan_loop);
       {
         Label continue_loop(&assembler);
         assembler.GotoUnless(
             assembler.UintPtrLessThan(index_var.value(), len_var.value()),
             &return_false);
         Node* element_k = assembler.LoadFixedArrayElement(
             elements, index_var.value(), 0,
             CodeStubAssembler::INTPTR_PARAMETERS);
         assembler.GotoIf(assembler.TaggedIsSmi(element_k), &continue_loop);
-        assembler.GotoIf(assembler.WordNotEqual(assembler.LoadMap(element_k),
-                                                heap_number_map),
-                         &continue_loop);
+        assembler.GotoUnless(
+            assembler.IsHeapNumberMap(assembler.LoadMap(element_k)),
+            &continue_loop);
         assembler.BranchIfFloat64IsNaN(assembler.LoadHeapNumberValue(element_k),
                                        &return_true, &continue_loop);
 
         assembler.Bind(&continue_loop);
         index_var.Bind(assembler.IntPtrAdd(index_var.value(), intptr_one));
         assembler.Goto(&nan_loop);
       }
     }
 
     assembler.Bind(&string_loop);
@@ skipping 53 matching lines @@
     Label nan_loop(&assembler, &index_var),
         not_nan_loop(&assembler, &index_var), hole_loop(&assembler, &index_var),
         search_notnan(&assembler);
     Variable search_num(&assembler, MachineRepresentation::kFloat64);
 
     assembler.GotoUnless(assembler.TaggedIsSmi(search_element), &search_notnan);
     search_num.Bind(assembler.SmiToFloat64(search_element));
     assembler.Goto(&not_nan_loop);
 
     assembler.Bind(&search_notnan);
-    assembler.GotoIf(assembler.WordNotEqual(assembler.LoadMap(search_element),
-                                            heap_number_map),
-                     &return_false);
+    assembler.GotoUnless(
+        assembler.IsHeapNumberMap(assembler.LoadMap(search_element)),
+        &return_false);
 
     search_num.Bind(assembler.LoadHeapNumberValue(search_element));
 
     assembler.BranchIfFloat64IsNaN(search_num.value(), &nan_loop,
                                    &not_nan_loop);
 
     // Search for HeapNumber
     assembler.Bind(&not_nan_loop);
     {
       Label continue_loop(&assembler);
@@ skipping 34 matching lines @@
         search_notnan(&assembler);
     Variable search_num(&assembler, MachineRepresentation::kFloat64);
 
     assembler.GotoUnless(assembler.TaggedIsSmi(search_element), &search_notnan);
     search_num.Bind(assembler.SmiToFloat64(search_element));
     assembler.Goto(&not_nan_loop);
 
     assembler.Bind(&search_notnan);
     assembler.GotoIf(assembler.WordEqual(search_element, undefined),
                      &hole_loop);
-    assembler.GotoIf(assembler.WordNotEqual(assembler.LoadMap(search_element),
-                                            heap_number_map),
-                     &return_false);
+    assembler.GotoUnless(
+        assembler.IsHeapNumberMap(assembler.LoadMap(search_element)),
+        &return_false);
 
     search_num.Bind(assembler.LoadHeapNumberValue(search_element));
 
     assembler.BranchIfFloat64IsNaN(search_num.value(), &nan_loop,
                                    &not_nan_loop);
 
     // Search for HeapNumber
     assembler.Bind(&not_nan_loop);
     {
       Label continue_loop(&assembler);
@@ skipping 68 matching lines @@
 
   Node* array = assembler.Parameter(0);
   Node* search_element = assembler.Parameter(1);
   Node* start_from = assembler.Parameter(2);
   Node* context = assembler.Parameter(3 + 2);
 
   Node* intptr_zero = assembler.IntPtrConstant(0);
   Node* intptr_one = assembler.IntPtrConstant(1);
 
   Node* undefined = assembler.UndefinedConstant();
-  Node* heap_number_map = assembler.HeapNumberMapConstant();
 
   Variable len_var(&assembler, MachineType::PointerRepresentation()),
       index_var(&assembler, MachineType::PointerRepresentation()),
       start_from_var(&assembler, MachineType::PointerRepresentation());
 
   Label init_k(&assembler), return_found(&assembler),
       return_not_found(&assembler), call_runtime(&assembler);
 
   Label init_len(&assembler);
 
@@ skipping 110 matching lines @@
         not_heap_num(&assembler);
 
     assembler.GotoUnless(assembler.TaggedIsSmi(search_element), &not_smi);
     search_num.Bind(assembler.SmiToFloat64(search_element));
     assembler.Goto(&heap_num_loop);
 
     assembler.Bind(&not_smi);
     assembler.GotoIf(assembler.WordEqual(search_element, undefined),
                      &undef_loop);
     Node* map = assembler.LoadMap(search_element);
-    assembler.GotoIf(assembler.WordNotEqual(map, heap_number_map),
-                     &not_heap_num);
+    assembler.GotoUnless(assembler.IsHeapNumberMap(map), &not_heap_num);
     search_num.Bind(assembler.LoadHeapNumberValue(search_element));
     assembler.Goto(&heap_num_loop);
 
     assembler.Bind(&not_heap_num);
     Node* search_type = assembler.LoadMapInstanceType(map);
     assembler.GotoIf(assembler.IsStringInstanceType(search_type), &string_loop);
     assembler.GotoIf(
         assembler.Word32Equal(search_type,
                               assembler.Int32Constant(SIMD128_VALUE_TYPE)),
         &simd_loop);
@@ skipping 42 matching lines @@
         Node* element_k = assembler.LoadFixedArrayElement(
             elements, index_var.value(), 0,
             CodeStubAssembler::INTPTR_PARAMETERS);
         assembler.GotoUnless(assembler.TaggedIsSmi(element_k), &not_smi);
         assembler.Branch(
             assembler.Float64Equal(search_num.value(),
                                    assembler.SmiToFloat64(element_k)),
             &return_found, &continue_loop);
 
         assembler.Bind(&not_smi);
-        assembler.GotoIf(assembler.WordNotEqual(assembler.LoadMap(element_k),
-                                                heap_number_map),
-                         &continue_loop);
+        assembler.GotoUnless(
+            assembler.IsHeapNumberMap(assembler.LoadMap(element_k)),
+            &continue_loop);
         assembler.Branch(
             assembler.Float64Equal(search_num.value(),
                                    assembler.LoadHeapNumberValue(element_k)),
             &return_found, &continue_loop);
 
         assembler.Bind(&continue_loop);
         index_var.Bind(assembler.IntPtrAdd(index_var.value(), intptr_one));
         assembler.Goto(&not_nan_loop);
       }
     }
@@ skipping 53 matching lines @@
   assembler.Bind(&if_packed_doubles);
   {
     Label not_nan_loop(&assembler, &index_var), search_notnan(&assembler);
     Variable search_num(&assembler, MachineRepresentation::kFloat64);
 
     assembler.GotoUnless(assembler.TaggedIsSmi(search_element), &search_notnan);
     search_num.Bind(assembler.SmiToFloat64(search_element));
     assembler.Goto(&not_nan_loop);
 
     assembler.Bind(&search_notnan);
-    assembler.GotoIf(assembler.WordNotEqual(assembler.LoadMap(search_element),
-                                            heap_number_map),
-                     &return_not_found);
+    assembler.GotoUnless(
+        assembler.IsHeapNumberMap(assembler.LoadMap(search_element)),
+        &return_not_found);
 
     search_num.Bind(assembler.LoadHeapNumberValue(search_element));
 
     assembler.BranchIfFloat64IsNaN(search_num.value(), &return_not_found,
                                    &not_nan_loop);
 
     // Search for HeapNumber
     assembler.Bind(&not_nan_loop);
     {
       Label continue_loop(&assembler);
@@ skipping 14 matching lines @@
   assembler.Bind(&if_holey_doubles);
   {
     Label not_nan_loop(&assembler, &index_var), search_notnan(&assembler);
     Variable search_num(&assembler, MachineRepresentation::kFloat64);
 
     assembler.GotoUnless(assembler.TaggedIsSmi(search_element), &search_notnan);
     search_num.Bind(assembler.SmiToFloat64(search_element));
     assembler.Goto(&not_nan_loop);
 
     assembler.Bind(&search_notnan);
-    assembler.GotoIf(assembler.WordNotEqual(assembler.LoadMap(search_element),
-                                            heap_number_map),
-                     &return_not_found);
+    assembler.GotoUnless(
+        assembler.IsHeapNumberMap(assembler.LoadMap(search_element)),
+        &return_not_found);
 
     search_num.Bind(assembler.LoadHeapNumberValue(search_element));
 
     assembler.BranchIfFloat64IsNaN(search_num.value(), &return_not_found,
                                    &not_nan_loop);
 
     // Search for HeapNumber
     assembler.Bind(&not_nan_loop);
     {
       Label continue_loop(&assembler);
@@ skipping 572 matching lines @@
         Runtime::kThrowIncompatibleMethodReceiver, context,
         assembler.HeapConstant(assembler.factory()->NewStringFromAsciiChecked(
             "Array Iterator.prototype.next", TENURED)),
         iterator);
     assembler.Return(result);
   }
 }
 
 }  // namespace internal
 }  // namespace v8