Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2543833004:
Add temporary Skia flags to guard new features (Closed)
DescriptionAdd temporary Skia flags to guard new features
(1) Constants in D50 matrices are being refined.
I expect this to cause layout test failures.
https://skia-review.googlesource.com/c/5450/
(2) Experimental color xform pipeline is causing
pixel diffs. Need a flag to keep this off.
https://bugs.chromium.org/p/chromium/issues/detail?id=670620
BUG=
Committed: https://crrev.com/fc318deb81c6fb9b66bbd55e6f636d0387e24405
Cr-Commit-Position: refs/heads/master@{#436001}
Patch Set 1 #Patch Set 2 : Add another flag #Messages
Total messages: 24 (16 generated)
msarett@chromium.org changed reviewers: + fmalita@chromium.org, msarett@chromium.org
The CQ bit was checked by msarett@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
msarett@chromium.org changed reviewers: + brianosman@google.com
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Use Skia legacy D50 matrices We will switch to more correct values later, which will require rebaselines. BUG= ========== to ========== Add temporary Skia flags to guard new features (1) Constants in D50 matrices are being refined. I expect this to cause layout test failures. https://skia-review.googlesource.com/c/5450/ (2) Experimental color xform pipeline is causing pixel diffs. Need a flag to keep this off. https://bugs.chromium.org/p/chromium/issues/detail?id=670620 BUG= ==========
Patchset #2 (id:20001) has been deleted
While we're here, looks like I'm going to need another flag.
The CQ bit was checked by msarett@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by msarett@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480703361695060,
"parent_rev": "f6b1e92e576681334d4098afe88241f5f8cc91fd", "commit_rev":
"b2ec0a8c1c3b2199314e13d393081e5ab4503beb"}
Message was sent while issue was closed.
Description was changed from ========== Add temporary Skia flags to guard new features (1) Constants in D50 matrices are being refined. I expect this to cause layout test failures. https://skia-review.googlesource.com/c/5450/ (2) Experimental color xform pipeline is causing pixel diffs. Need a flag to keep this off. https://bugs.chromium.org/p/chromium/issues/detail?id=670620 BUG= ========== to ========== Add temporary Skia flags to guard new features (1) Constants in D50 matrices are being refined. I expect this to cause layout test failures. https://skia-review.googlesource.com/c/5450/ (2) Experimental color xform pipeline is causing pixel diffs. Need a flag to keep this off. https://bugs.chromium.org/p/chromium/issues/detail?id=670620 BUG= ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Add temporary Skia flags to guard new features (1) Constants in D50 matrices are being refined. I expect this to cause layout test failures. https://skia-review.googlesource.com/c/5450/ (2) Experimental color xform pipeline is causing pixel diffs. Need a flag to keep this off. https://bugs.chromium.org/p/chromium/issues/detail?id=670620 BUG= ========== to ========== Add temporary Skia flags to guard new features (1) Constants in D50 matrices are being refined. I expect this to cause layout test failures. https://skia-review.googlesource.com/c/5450/ (2) Experimental color xform pipeline is causing pixel diffs. Need a flag to keep this off. https://bugs.chromium.org/p/chromium/issues/detail?id=670620 BUG= Committed: https://crrev.com/fc318deb81c6fb9b66bbd55e6f636d0387e24405 Cr-Commit-Position: refs/heads/master@{#436001} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/fc318deb81c6fb9b66bbd55e6f636d0387e24405 Cr-Commit-Position: refs/heads/master@{#436001} |
