Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Issue 2543833002: Protect against unexpected library create/destroy (Closed)

Created:
4 years ago by Tom Sepez
Modified:
4 years ago
Reviewers:
Lei Zhang, npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Protect against unexpected library create/destroy Probably won't fix bug 669797 on its own, but nice to have. Remove unimplemented static method. Committed: https://pdfium.googlesource.com/pdfium/+/02759102cf998c9e937b3b65b64ed6b4c3b104bc

Patch Set 1 #

Patch Set 2 : Less code #

Patch Set 3 : Fix #

Patch Set 4 : Add unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -3 lines) Patch
M BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M core/fpdfapi/cpdf_modulemgr.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/fpdfview.cpp View 1 2 3 chunks +10 lines, -2 lines 0 comments Download
A fpdfsdk/fpdfview_unittest.cpp View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (19 generated)
Tom Sepez
Lei (if !OOO), NPM, ready for review.
4 years ago (2016-12-01 00:27:51 UTC) #11
npm
lgtm
4 years ago (2016-12-01 15:24:42 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2543833002/60001
4 years ago (2016-12-01 16:29:10 UTC) #20
commit-bot: I haz the power
4 years ago (2016-12-01 16:29:30 UTC) #23
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/02759102cf998c9e937b3b65b64ed6b4c3b1...

Powered by Google App Engine
This is Rietveld 408576698