Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2543773002: [Turbofan] Canonicalize SIMD 32x4 Select, Swizzle, and Shuffle. (Closed)

Created:
4 years ago by bbudge
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Turbofan] Canonicalize SIMD 32x4 Select, Swizzle, and Shuffle. - These operations are identical for Float32x4 and Int32x4. - Make them generic, following the naming for generic Simd128 / S128 opcodes. - F32x4/I32x4 -> S32x4, similarly to S128 - Float32x4/Int32x4 -> Simd32x4, similarly to Simd128. LOG=N BUG=v8:4124 Committed: https://crrev.com/df9deb5381dbf6e87e659bbad95e8b791b423554 Cr-Commit-Position: refs/heads/master@{#41437}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -26 lines) Patch
M src/compiler/instruction-selector.h View 1 chunk +1 line, -2 lines 1 comment Download
M src/compiler/machine-operator.h View 3 chunks +3 lines, -6 lines 0 comments Download
M src/compiler/machine-operator.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M src/compiler/opcodes.h View 3 chunks +4 lines, -7 lines 0 comments Download
M src/wasm/wasm-opcodes.h View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
bbudge
Brad review concept. Mircea for OWNERS. https://codereview.chromium.org/2543773002/diff/1/src/compiler/instruction-selector.h File src/compiler/instruction-selector.h (left): https://codereview.chromium.org/2543773002/diff/1/src/compiler/instruction-selector.h#oldcode311 src/compiler/instruction-selector.h:311: MACHINE_SIMD_RETURN_SIMD_OP_LIST(DECLARE_GENERATOR) This is ...
4 years ago (2016-11-30 22:10:10 UTC) #2
bradnelson
lgtm
4 years ago (2016-11-30 22:13:59 UTC) #5
Mircea Trofin
On 2016/11/30 22:13:59, bradnelson wrote: > lgtm lgtm
4 years ago (2016-11-30 22:20:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2543773002/1
4 years ago (2016-12-01 19:51:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 19:53:13 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-01 19:53:29 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df9deb5381dbf6e87e659bbad95e8b791b423554
Cr-Commit-Position: refs/heads/master@{#41437}

Powered by Google App Engine
This is Rietveld 408576698