Move processing of instance members from ResolutionEnqueuer to ResolutionWorldBuilderImpl

Move processing of instance members from ResolutionEnqueuer to ResolutionWorldBuilderImpl

R=het@google.com

Committed: https://github.com/dart-lang/sdk/commit/662feb94d7ad205f44c93eaf356f34de6fdd658d

[Johnni Winther, 2016-12-02 14:50:29]

johnniwinther@google.com changed reviewers:
+ het@google.com

[Johnni Winther, 2016-12-05 10:34:28]

ping

[Harry Terkelsen, 2016-12-05 22:48:53]

lgtm

https://codereview.chromium.org/2543753004/diff/1/pkg/compiler/lib/src/univer...
File pkg/compiler/lib/src/universe/world_builder.dart (right):

https://codereview.chromium.org/2543753004/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/world_builder.dart:724: set.where((MemberUsage
usage) => usage.member == element).toList());
is toList() necessary to prevent the 'where' from failing because of the set
changing?

https://codereview.chromium.org/2543753004/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/world_builder.dart:756: void
_processInstanceMembers(String n, bool f(MemberUsage e)) {
give these params full names

https://codereview.chromium.org/2543753004/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/world_builder.dart:1110: /// `true` if [member]
has be read as a value. For a field this is a normal
be -> been

https://codereview.chromium.org/2543753004/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/world_builder.dart:1114: /// `true` if a value as
been written to [member].
as -> has

https://codereview.chromium.org/2543753004/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/world_builder.dart:1324: EnumSet<MemberUse> get
_originalUse => MemberUse.NORMAL_ONLY;
maybe make _originalUse have a default NORMAL_ONLY implementation in MemberUse
and only override it in _FunctionUsage?

https://codereview.chromium.org/2543753004/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/world_builder.dart:1343: class MemberUse {
why not just use an actual enum? and move the static enumsets outside the class?

https://codereview.chromium.org/2543753004/diff/1/pkg/compiler/lib/src/util/e...
File pkg/compiler/lib/src/util/enumset.dart (right):

https://codereview.chromium.org/2543753004/diff/1/pkg/compiler/lib/src/util/e...
pkg/compiler/lib/src/util/enumset.dart:53: /// Returns a new set containing all
values in both this bot _not_ in the
"containing all values in this set that are not in the other set"

[Johnni Winther, 2016-12-06 09:28:06]

https://codereview.chromium.org/2543753004/diff/1/pkg/compiler/lib/src/univer...
File pkg/compiler/lib/src/universe/world_builder.dart (right):

https://codereview.chromium.org/2543753004/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/world_builder.dart:724: set.where((MemberUsage
usage) => usage.member == element).toList());
On 2016/12/05 22:48:53, Harry Terkelsen wrote:
> is toList() necessary to prevent the 'where' from failing because of the set
> changing?

Yes.

https://codereview.chromium.org/2543753004/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/world_builder.dart:756: void
_processInstanceMembers(String n, bool f(MemberUsage e)) {
On 2016/12/05 22:48:53, Harry Terkelsen wrote:
> give these params full names

Done.

https://codereview.chromium.org/2543753004/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/world_builder.dart:1110: /// `true` if [member]
has be read as a value. For a field this is a normal
On 2016/12/05 22:48:53, Harry Terkelsen wrote:
> be -> been

Done.

https://codereview.chromium.org/2543753004/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/world_builder.dart:1114: /// `true` if a value as
been written to [member].
On 2016/12/05 22:48:53, Harry Terkelsen wrote:
> as -> has

Done.

https://codereview.chromium.org/2543753004/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/world_builder.dart:1324: EnumSet<MemberUse> get
_originalUse => MemberUse.NORMAL_ONLY;
On 2016/12/05 22:48:53, Harry Terkelsen wrote:
> maybe make _originalUse have a default NORMAL_ONLY implementation in MemberUse
> and only override it in _FunctionUsage?

Done.

https://codereview.chromium.org/2543753004/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/world_builder.dart:1343: class MemberUse {
On 2016/12/05 22:48:53, Harry Terkelsen wrote:
> why not just use an actual enum? and move the static enumsets outside the
class?

Done.

https://codereview.chromium.org/2543753004/diff/1/pkg/compiler/lib/src/util/e...
File pkg/compiler/lib/src/util/enumset.dart (right):

https://codereview.chromium.org/2543753004/diff/1/pkg/compiler/lib/src/util/e...
pkg/compiler/lib/src/util/enumset.dart:53: /// Returns a new set containing all
values in both this bot _not_ in the
On 2016/12/05 22:48:53, Harry Terkelsen wrote:
> "containing all values in this set that are not in the other set"

Done.

[Johnni Winther, 2016-12-06 09:32:40]

Description was changed from

==========
Move processing of instance members from ResolutionEnqueuer to
ResolutionWorldBuilderImpl
==========

to

==========
Move processing of instance members from ResolutionEnqueuer to
ResolutionWorldBuilderImpl

R=het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/662feb94d7ad205f44c93eaf356f34de6fdd658d
==========

[Johnni Winther, 2016-12-06 09:32:41]

Committed patchset #2 (id:20001) manually as
662feb94d7ad205f44c93eaf356f34de6fdd658d (presubmit successful).