Remove MainThreadTaskRunner

Remove MainThreadTaskRunner

This CL removes MainThreadTaskRunner, and implements its task cancellation
and instrumentation directly in Document.

Committed: https://crrev.com/91027149fe1afc1872f419f8c2f52ac7644ee678
Cr-Commit-Position: refs/heads/master@{#436574}

[tzik, 2016-12-02 05:26:13]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 05:26:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 05:28:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 05:28:37]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[tzik, 2016-12-02 07:19:52]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 07:20:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 07:23:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 07:23:08]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tzik, 2016-12-02 09:07:00]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 09:07:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2016-12-02 10:13:30]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 10:13:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2016-12-02 10:26:00]

Description was changed from

==========
Remove MainThreadTaskRunner

BUG=
==========

to

==========
Remove MainThreadTaskRunner

This CL removes MainThreadTaskRunner, and implements its task cancellation
and instrumentation directly in Document.
==========

[tzik, 2016-12-02 10:26:04]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 10:26:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2016-12-02 10:26:57]

tzik@chromium.org changed reviewers:
+ haraken@chromium.org

[tzik, 2016-12-02 10:26:57]

PTAL

[haraken, 2016-12-02 11:33:50]

LGTM

[commit-bot: I haz the power, 2016-12-02 11:59:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 12:00:00]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tzik, 2016-12-05 12:13:35]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 12:13:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 13:47:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 13:47:55]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tzik, 2016-12-06 06:29:37]

The CQ bit was checked by tzik@chromium.org

[tzik, 2016-12-06 06:29:37]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2543723005/#ps100001
(title: "rebase, fix")

[commit-bot: I haz the power, 2016-12-06 06:29:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 07:24:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 07:24:27]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[tzik, 2016-12-06 08:52:13]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2016-12-06 08:52:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 09:25:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 09:25:08]

Failed to apply patch for third_party/WebKit/Source/core/dom/Document.cpp:
While running git apply --index -p1;
  error: patch failed: third_party/WebKit/Source/core/dom/Document.cpp:87
  error: third_party/WebKit/Source/core/dom/Document.cpp: patch does not apply

Patch:       third_party/WebKit/Source/core/dom/Document.cpp
Index: third_party/WebKit/Source/core/dom/Document.cpp
diff --git a/third_party/WebKit/Source/core/dom/Document.cpp
b/third_party/WebKit/Source/core/dom/Document.cpp
index
918fe8920fc185a7b77e0888895ed187d1baf7e1..fa2e7b1d24af11ea2af62963acf5d884358b99c1
100644
--- a/third_party/WebKit/Source/core/dom/Document.cpp
+++ b/third_party/WebKit/Source/core/dom/Document.cpp
@@ -87,7 +87,6 @@
 #include "core/dom/FrameRequestCallback.h"
 #include "core/dom/IntersectionObserverController.h"
 #include "core/dom/LayoutTreeBuilderTraversal.h"
-#include "core/dom/MainThreadTaskRunner.h"
 #include "core/dom/MutationObserver.h"
 #include "core/dom/NodeChildRemovalTracker.h"
 #include "core/dom/NodeComputedStyle.h"
@@ -473,7 +472,6 @@ Document::Document(const DocumentInit& initializer,
       m_documentTiming(*this),
       m_writeRecursionIsTooDeep(false),
       m_writeRecursionDepth(0),
-      m_taskRunner(MainThreadTaskRunner::create(this)),
       m_registrationContext(initializer.registrationContext(this)),
       m_elementDataCacheClearTimer(
           TaskRunnerHelper::get(TaskType::Internal, this),
@@ -4351,6 +4349,14 @@ void Document::sendSensitiveInputVisibilityInternal() {
   sensitiveInputServicePtr->AllPasswordFieldsInInsecureContextInvisible();
 }
 
+void Document::runExecutionContextTask(
+    std::unique_ptr<ExecutionContextTask> task,
+    bool isInstrumented) {
+  InspectorInstrumentation::AsyncTask asyncTask(this, task.get(),
+                                                isInstrumented);
+  task->performTask(this);
+}
+
 void Document::registerEventFactory(
     std::unique_ptr<EventFactoryBase> eventFactory) {
   DCHECK(!eventFactories().contains(eventFactory.get()));
@@ -5708,11 +5714,10 @@ static void runAddConsoleMessageTask(MessageSource
source,
 
 void Document::addConsoleMessage(ConsoleMessage* consoleMessage) {
   if (!isContextThread()) {
-    m_taskRunner->postTask(
-        BLINK_FROM_HERE,
-        createCrossThreadTask(&runAddConsoleMessageTask,
-                              consoleMessage->source(),
consoleMessage->level(),
-                              consoleMessage->message()));
+    postTask(BLINK_FROM_HERE, createCrossThreadTask(&runAddConsoleMessageTask,
+                                                    consoleMessage->source(),
+                                                    consoleMessage->level(),
+                                                   
consoleMessage->message()));
     return;
   }
 
@@ -5735,11 +5740,21 @@ void Document::addConsoleMessage(ConsoleMessage*
consoleMessage) {
   m_frame->console().addMessage(consoleMessage);
 }
 
-void Document::postTask(TaskType,
+void Document::postTask(TaskType taskType,
                         const WebTraceLocation& location,
                         std::unique_ptr<ExecutionContextTask> task,
                         const String& taskNameForInstrumentation) {
-  m_taskRunner->postTask(location, std::move(task),
taskNameForInstrumentation);
+  if (!taskNameForInstrumentation.isEmpty()) {
+    InspectorInstrumentation::asyncTaskScheduled(
+        this, taskNameForInstrumentation, task.get());
+  }
+
+  TaskRunnerHelper::get(taskType, this)
+      ->postTask(location,
+                 crossThreadBind(&Document::runExecutionContextTask,
+                                 wrapCrossThreadWeakPersistent(this),
+                                 WTF::passed(std::move(task)),
+                                 !taskNameForInstrumentation.isEmpty()));
 }
 
 void Document::tasksWereSuspended() {
@@ -6273,8 +6288,7 @@ void Document::setAutofocusElement(Element* element) {
   m_hasAutofocused = true;
   DCHECK(!m_autofocusElement);
   m_autofocusElement = element;
-  m_taskRunner->postTask(BLINK_FROM_HERE,
-                         createSameThreadTask(&runAutofocusTask));
+  postTask(BLINK_FROM_HERE, createSameThreadTask(&runAutofocusTask));
 }
 
 Element* Document::activeElement() const {

[tzik, 2016-12-06 10:30:33]

The CQ bit was checked by tzik@chromium.org

[tzik, 2016-12-06 10:30:33]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2543723005/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2016-12-06 10:30:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 12:01:36]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1481020233134540,
"parent_rev": "81ce2c5af1df02e186526bd2b4c6e3857425bdbf", "commit_rev":
"7c9091bde9229c43353fb03737f5737e72f19f5b"}

[commit-bot: I haz the power, 2016-12-06 12:02:21]

Description was changed from

==========
Remove MainThreadTaskRunner

This CL removes MainThreadTaskRunner, and implements its task cancellation
and instrumentation directly in Document.
==========

to

==========
Remove MainThreadTaskRunner

This CL removes MainThreadTaskRunner, and implements its task cancellation
and instrumentation directly in Document.
==========

[commit-bot: I haz the power, 2016-12-06 12:02:23]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-12-06 12:03:33]

Description was changed from

==========
Remove MainThreadTaskRunner

This CL removes MainThreadTaskRunner, and implements its task cancellation
and instrumentation directly in Document.
==========

to

==========
Remove MainThreadTaskRunner

This CL removes MainThreadTaskRunner, and implements its task cancellation
and instrumentation directly in Document.

Committed: https://crrev.com/91027149fe1afc1872f419f8c2f52ac7644ee678
Cr-Commit-Position: refs/heads/master@{#436574}
==========

[commit-bot: I haz the power, 2016-12-06 12:03:35]

Patchset 7 (id:??) landed as
https://crrev.com/91027149fe1afc1872f419f8c2f52ac7644ee678
Cr-Commit-Position: refs/heads/master@{#436574}