Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2543713002: Add a new Analysis Server option '--new-analysis-driver-log'. (Closed)

Created:
4 years ago by scheglov
Modified:
4 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a new Analysis Server option '--new-analysis-driver-log'. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/4686d364bbe9a2fb0ebf469380c22db87a7543d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -2 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 4 chunks +23 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/server/driver.dart View 4 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years ago (2016-11-30 19:04:18 UTC) #1
Brian Wilkerson
Thanks! I ran into some failing tests because of the prints. lgtm
4 years ago (2016-11-30 19:56:29 UTC) #2
scheglov
4 years ago (2016-11-30 20:10:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4686d364bbe9a2fb0ebf469380c22db87a7543d5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698