Source/bindings/core/dart/DartController.cpp - Issue 2543703003: Added setting up VMLibraryHooks for Dartium to support resolvePageUri

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/dart/DartController.cpp

Issue 2543703003: Added setting up VMLibraryHooks for Dartium to support resolvePageUri (Closed)

Patch Set: Incorporated Siva suggestion Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/dart/DartController.cpp

diff --git a/Source/bindings/core/dart/DartController.cpp b/Source/bindings/core/dart/DartController.cpp

index 4ffedaa560a40144de4128e980cdaa325d60e167..cc7b2af7c5c83cc939316b10b87bec48eab49065 100644

--- a/Source/bindings/core/dart/DartController.cpp

+++ b/Source/bindings/core/dart/DartController.cpp

@@ -744,7 +744,7 @@ void DartController::initVMIfNeeded(bool checked, Document* document)

init_params.entropy_source = generateEntropy;

init_params.get_service_assets = GetVMServiceAssetsArchiveCallback;

char* error = Dart_Initialize(&init_params);

- RELEASE_ASSERT_WITH_MESSAGE(!error, error);

+ RELEASE_ASSERT_WITH_MESSAGE(!error, "Dart_Initialize failed");

}

static bool checkForExpiration()