Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 25437010: Skip WritePixels test on Xoom (Closed)

Created:
7 years, 2 months ago by borenet
Modified:
7 years, 2 months ago
Reviewers:
bsalomon, rmistry, caryclark
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M slave/skia_slave_scripts/run_tests.py View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
borenet
7 years, 2 months ago (2013-10-04 15:16:19 UTC) #1
rmistry
LGTM https://codereview.chromium.org/25437010/diff/1/slave/skia_slave_scripts/run_tests.py File slave/skia_slave_scripts/run_tests.py (right): https://codereview.chromium.org/25437010/diff/1/slave/skia_slave_scripts/run_tests.py#newcode15 slave/skia_slave_scripts/run_tests.py:15: if 'Xoom' in self._builder_name: Can you add a ...
7 years, 2 months ago (2013-10-04 15:18:21 UTC) #2
borenet
Patch set 2. https://codereview.chromium.org/25437010/diff/1/slave/skia_slave_scripts/run_tests.py File slave/skia_slave_scripts/run_tests.py (right): https://codereview.chromium.org/25437010/diff/1/slave/skia_slave_scripts/run_tests.py#newcode15 slave/skia_slave_scripts/run_tests.py:15: if 'Xoom' in self._builder_name: On 2013/10/04 ...
7 years, 2 months ago (2013-10-04 15:24:43 UTC) #3
caryclark
lgtm
7 years, 2 months ago (2013-10-04 15:28:38 UTC) #4
borenet
7 years, 2 months ago (2013-10-04 15:30:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r11610 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698