Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2543683002: Revert of [ObjC ARC] Converts ios/chrome/browser/ui/autofill:autofill to ARC.Automatically generated ARCMig… (Closed)

Created:
4 years ago by sdefresne
Modified:
4 years ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, sebsg+autofillwatch_chromium.org, pkl (ping after 24h if needed), jdonnelly+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, mac-reviews_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [ObjC ARC] Converts ios/chrome/browser/ui/autofill:autofill to ARC.Automatically generated ARCMig… (patchset #1 id:1 of https://codereview.chromium.org/2513003002/ ) Reason for revert: This break the roll because id<AutofillClientIOSBridge> was a weak reference and is now turned into a strong reference. Since the id<AutofillClientIOSBridge> owns the AutofillClientIOS in the downstream tree this causes a reference cycle and cause a SigninManagerBase::Observer to survive the destruction of SigninManagerBase. Original issue's description: > [ObjC ARC] Converts ios/chrome/browser/ui/autofill:autofill to ARC. > > Automatically generated ARCMigrate commit > Notable issues:None > BUG=624363 > TEST=None > > Committed: https://crrev.com/bb77ce777e93d29d2bd6969e70da4c11708c1c5a > Cr-Commit-Position: refs/heads/master@{#435285} TBR=jdonnelly@chromium.org,stkhapugin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624363 Committed: https://crrev.com/6003cf9974cf584ae8523e02a0bc001178fb73ae Cr-Commit-Position: refs/heads/master@{#435336}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M ios/chrome/browser/ui/autofill/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/autofill/autofill_client_ios.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/autofill/autofill_save_card_infobar.mm View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
sdefresne
4 years ago (2016-11-30 18:02:29 UTC) #2
Created Revert of [ObjC ARC] Converts ios/chrome/browser/ui/autofill:autofill to
ARC.Automatically generated ARCMig…

Powered by Google App Engine
This is Rietveld 408576698