Add support for more AVX instructions.

Add support for more AVX2 instructions.

This isn't the whole AVX2 instruction set but this will unblock the SyzyAsan builds.

BUG=669784
Committed: https://github.com/google/syzygy/commit/226ab514b7a1ea50316a30045090f830390cb138

[Sébastien Marchand, 2016-11-30 16:33:56]

Description was changed from

==========
Add support for more AVX instructions.

BUG=669784
==========

to

==========
Add support for more AVX2 instructions.

This isn't the whole AVX2 instruction set but this will unblock the SyzyAsan
builds.

BUG=669784
==========

[Sébastien Marchand, 2016-11-30 16:33:57]

sebmarchand@chromium.org changed reviewers:
+ chrisha@chromium.org, siggi@chromium.org

[Sébastien Marchand, 2016-11-30 16:34:04]

PTAL

https://codereview.chromium.org/2543673002/diff/1/syzygy/core/disassembler_ut...
File syzygy/core/disassembler_util.cc (left):

https://codereview.chromium.org/2543673002/diff/1/syzygy/core/disassembler_ut...
syzygy/core/disassembler_util.cc:52: case 0x01: {
This wasn't corresponding to any real instruction.

[Sigurður Ásgeirsson, 2016-11-30 16:38:09]

LGTM with a small nit.

https://codereview.chromium.org/2543673002/diff/1/syzygy/core/disassembler_ut...
File syzygy/core/disassembler_util.cc (right):

https://codereview.chromium.org/2543673002/diff/1/syzygy/core/disassembler_ut...
syzygy/core/disassembler_util.cc:90: instruction_bytes +=
base::StringPrintf("%02X", ci->code[i]);
ubernit: Don't we have a StringAppendf or the like?

[Sébastien Marchand, 2016-11-30 16:43:42]

Thanks, committing.

https://codereview.chromium.org/2543673002/diff/1/syzygy/core/disassembler_ut...
File syzygy/core/disassembler_util.cc (right):

https://codereview.chromium.org/2543673002/diff/1/syzygy/core/disassembler_ut...
syzygy/core/disassembler_util.cc:90: instruction_bytes +=
base::StringPrintf("%02X", ci->code[i]);
On 2016/11/30 16:38:09, Sigurður Ásgeirsson wrote:
> ubernit: Don't we have a StringAppendf or the like?

Good point.

[Sébastien Marchand, 2016-11-30 16:56:52]

The CQ bit was checked by sebmarchand@chromium.org

[Sébastien Marchand, 2016-11-30 16:56:52]

The patchset sent to the CQ was uploaded after l-g-t-m from siggi@chromium.org
Link to the patchset: https://codereview.chromium.org/2543673002/#ps20001
(title: "Address nit.")

[commit-bot: I haz the power, 2016-11-30 16:56:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 17:23:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480525012217660,
"parent_rev": "92eaead8dea7d85a6d1b43b72fa6aba00a9cdb38", "commit_rev":
"226ab514b7a1ea50316a30045090f830390cb138"}

[commit-bot: I haz the power, 2016-11-30 17:23:57]

Description was changed from

==========
Add support for more AVX2 instructions.

This isn't the whole AVX2 instruction set but this will unblock the SyzyAsan
builds.

BUG=669784
==========

to

==========
Add support for more AVX2 instructions.

This isn't the whole AVX2 instruction set but this will unblock the SyzyAsan
builds.

BUG=669784

Committed:
https://github.com/google/syzygy/commit/226ab514b7a1ea50316a30045090f830390cb138
==========

[commit-bot: I haz the power, 2016-11-30 17:23:58]

Committed patchset #2 (id:20001) as
https://github.com/google/syzygy/commit/226ab514b7a1ea50316a30045090f830390cb138