Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2543663003: generate GL_INVALID_VALUE for CheckedNumeric invalid operations (Closed)

Created:
4 years ago by Kai Ninomiya
Modified:
4 years ago
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, haraken, Rik, f(malita), blink-reviews, piman+watch_chromium.org, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

generate GL_INVALID_VALUE for CheckedNumeric invalid operations BUG=670120 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/71e4a0c3dd002c060b060dbb8bee3bd210a89b97 Cr-Commit-Position: refs/heads/master@{#435767}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 chunk +8 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
Kai Ninomiya
kbr, PTAL
4 years ago (2016-12-01 00:47:28 UTC) #5
Ken Russell (switch to Gerrit)
Thanks for cleaning these up. LGTM
4 years ago (2016-12-01 23:36:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2543663003/1
4 years ago (2016-12-01 23:39:13 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 23:46:02 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-01 23:47:35 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71e4a0c3dd002c060b060dbb8bee3bd210a89b97
Cr-Commit-Position: refs/heads/master@{#435767}

Powered by Google App Engine
This is Rietveld 408576698