Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2543663002: Provide simple wrappers for base/time types in WTF (Closed)

Created:
4 years ago by majidvp
Modified:
4 years ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Provide simple wrappers for base/time types in WTF - WTF::TimeDelta aliased base::TimeDelta - WTF::{Time,TimeTicks} are a thin wrapper around base::{Time,TimeTicks} this is mainly because we want to control the API surface we expose in particular we want to avoid exposing string parsing functions at this time. Once we have these types we can start replacing usage of double and int to represent time in blink with more accurate and type safe representations. Relevant discussion: https://groups.google.com/a/chromium.org/d/msg/platform-architecture-dev/7kg1FAsXkng/l19cEeBPBAAJ BUG=625680, 402027 TEST=Critical functionality is already covered in base/time/time_unittest.cc but added a smoke test in TimeTest.cpp Committed: https://crrev.com/57f212f9329a3ceec41e466a31b4b83508041e2b Cr-Commit-Position: refs/heads/master@{#436084}

Patch Set 1 #

Patch Set 2 : clean up #

Patch Set 3 : Consistent mocking #

Messages

Total messages: 19 (14 generated)
majidvp
esprehn@: PTAL and let me know if this approach makes sense. This is an example ...
4 years ago (2016-11-30 22:23:45 UTC) #9
esprehn
lgtm
4 years ago (2016-12-02 20:29:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2543663002/40001
4 years ago (2016-12-02 20:45:36 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-02 23:53:42 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-02 23:57:02 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/57f212f9329a3ceec41e466a31b4b83508041e2b
Cr-Commit-Position: refs/heads/master@{#436084}

Powered by Google App Engine
This is Rietveld 408576698