Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2543643005: MIPS[64]: Fix tests for macro-assembler. (Closed)

Created:
4 years ago by Ilija.Pavlovic1
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS[64]: Fix compilation failure in test-macro-assembler[64].cc Fix compilation failure in test-macro-assembler[64].cc caused by 8fcfe66f9458e2dd1009d4854786aec428d5cc59 due to warning `lambda-expression in unevaluated context`. TEST=cctest/test-macro-assembler-mips[64] BUG= Committed: https://crrev.com/a1901cfbc7c07e81f1e3334c8b3ad21baddc6103 Cr-Commit-Position: refs/heads/master@{#41433}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+322 lines, -307 lines) Patch
M test/cctest/test-macro-assembler-mips.cc View 8 chunks +115 lines, -109 lines 0 comments Download
M test/cctest/test-macro-assembler-mips64.cc View 14 chunks +207 lines, -198 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Ilija.Pavlovic1
PTAL
4 years ago (2016-12-01 15:44:16 UTC) #2
ivica.bogosavljevic
lgtm with nits: The title should be: MIPS[64]: Fix compilation failure in test-macro-assembler[64].cc Fix compilation ...
4 years ago (2016-12-01 15:49:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2543643005/1
4 years ago (2016-12-01 15:53:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 16:15:38 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-01 16:16:14 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1901cfbc7c07e81f1e3334c8b3ad21baddc6103
Cr-Commit-Position: refs/heads/master@{#41433}

Powered by Google App Engine
This is Rietveld 408576698