Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: src/full-codegen/s390/full-codegen-s390.cc

Issue 2543643002: [fullcodegen] Remove deprecated support for computed property names. (Closed)
Patch Set: Delete runtime call in VisitObjectLiteral. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/ppc/full-codegen-ppc.cc ('k') | src/full-codegen/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_S390 5 #if V8_TARGET_ARCH_S390
6 6
7 #include "src/full-codegen/full-codegen.h" 7 #include "src/full-codegen/full-codegen.h"
8 #include "src/ast/compile-time-value.h" 8 #include "src/ast/compile-time-value.h"
9 #include "src/ast/scopes.h" 9 #include "src/ast/scopes.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 1276 matching lines...) Expand 10 before | Expand all | Expand 10 after
1287 EmitPropertyKey(property, expr->GetIdForPropertyName(property_index)); 1287 EmitPropertyKey(property, expr->GetIdForPropertyName(property_index));
1288 VisitForStackValue(value); 1288 VisitForStackValue(value);
1289 if (NeedsHomeObject(value)) { 1289 if (NeedsHomeObject(value)) {
1290 EmitSetHomeObject(value, 2, property->GetSlot()); 1290 EmitSetHomeObject(value, 2, property->GetSlot());
1291 } 1291 }
1292 1292
1293 switch (property->kind()) { 1293 switch (property->kind()) {
1294 case ObjectLiteral::Property::CONSTANT: 1294 case ObjectLiteral::Property::CONSTANT:
1295 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1295 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1296 case ObjectLiteral::Property::COMPUTED: 1296 case ObjectLiteral::Property::COMPUTED:
1297 if (property->emit_store()) {
1298 PushOperand(Smi::FromInt(NONE));
1299 PushOperand(Smi::FromInt(property->NeedsSetFunctionName()));
1300 CallRuntimeWithOperands(Runtime::kDefineDataPropertyInLiteral);
1301 PrepareForBailoutForId(expr->GetIdForPropertySet(property_index),
1302 BailoutState::NO_REGISTERS);
1303 } else {
1304 DropOperands(3);
1305 }
1306 break;
1307
1308 case ObjectLiteral::Property::PROTOTYPE: 1297 case ObjectLiteral::Property::PROTOTYPE:
1309 UNREACHABLE(); 1298 UNREACHABLE();
1310 break; 1299 break;
1311 1300
1312 case ObjectLiteral::Property::GETTER: 1301 case ObjectLiteral::Property::GETTER:
1313 PushOperand(Smi::FromInt(NONE)); 1302 PushOperand(Smi::FromInt(NONE));
1314 CallRuntimeWithOperands(Runtime::kDefineGetterPropertyUnchecked); 1303 CallRuntimeWithOperands(Runtime::kDefineGetterPropertyUnchecked);
1315 break; 1304 break;
1316 1305
1317 case ObjectLiteral::Property::SETTER: 1306 case ObjectLiteral::Property::SETTER:
(...skipping 1756 matching lines...) Expand 10 before | Expand all | Expand 10 after
3074 DCHECK(kOSRBranchInstruction == br_instr); 3063 DCHECK(kOSRBranchInstruction == br_instr);
3075 3064
3076 DCHECK(interrupt_address == 3065 DCHECK(interrupt_address ==
3077 isolate->builtins()->OnStackReplacement()->entry()); 3066 isolate->builtins()->OnStackReplacement()->entry());
3078 return ON_STACK_REPLACEMENT; 3067 return ON_STACK_REPLACEMENT;
3079 } 3068 }
3080 3069
3081 } // namespace internal 3070 } // namespace internal
3082 } // namespace v8 3071 } // namespace v8
3083 #endif // V8_TARGET_ARCH_S390 3072 #endif // V8_TARGET_ARCH_S390
OLDNEW
« no previous file with comments | « src/full-codegen/ppc/full-codegen-ppc.cc ('k') | src/full-codegen/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698