Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2543633009: [Devtools] Template fromTarget() function calls to model (Closed)

Created:
4 years ago by allada
Modified:
4 years ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Template fromTarget() function calls to model This patch is for code health, it only modifies the JSDocs to add template types to fromTarget calls on the SDKModels, so the developer does not need to explicitly cast them. R=lushnikov BUG=None Committed: https://crrev.com/df3a33988beebfe1b9341346e3437711622e5a83 Cr-Commit-Position: refs/heads/master@{#436164}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -18 lines) Patch
M third_party/WebKit/Source/devtools/front_end/layers/LayerTreeModel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/DOMStorageModel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/IndexedDBModel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ApplicationCacheModel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/SecurityOriginManager.js View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/Target.js View 1 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
allada
PTL
4 years ago (2016-12-02 23:00:15 UTC) #1
lushnikov
lgtm! Could you please also check that closure indeed infers the type properly? (e.g. try ...
4 years ago (2016-12-03 00:36:23 UTC) #4
allada
done https://codereview.chromium.org/2543633009/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/Target.js File third_party/WebKit/Source/devtools/front_end/sdk/Target.js (right): https://codereview.chromium.org/2543633009/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/Target.js#newcode138 third_party/WebKit/Source/devtools/front_end/sdk/Target.js:138: /** On 2016/12/03 00:36:23, lushnikov wrote: > nit: ...
4 years ago (2016-12-03 02:12:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2543633009/20001
4 years ago (2016-12-03 02:12:47 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-03 04:07:11 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-03 04:10:32 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/df3a33988beebfe1b9341346e3437711622e5a83
Cr-Commit-Position: refs/heads/master@{#436164}

Powered by Google App Engine
This is Rietveld 408576698