[Devtools] Template fromTarget() function calls to model

[Devtools] Template fromTarget() function calls to model

This patch is for code health, it only modifies the JSDocs to add
template types to fromTarget calls on the SDKModels, so the developer
does not need to explicitly cast them.

R=lushnikov
BUG=None

Committed: https://crrev.com/df3a33988beebfe1b9341346e3437711622e5a83
Cr-Commit-Position: refs/heads/master@{#436164}

[allada, 2016-12-02 23:00:15]

PTL

[allada, 2016-12-02 23:00:19]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 23:01:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2016-12-03 00:36:23]

lgtm!

Could you please also check that closure indeed infers the type properly? (e.g.
try to call non-existent method and see if it will complain)

https://codereview.chromium.org/2543633009/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/Target.js (right):

https://codereview.chromium.org/2543633009/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/Target.js:138: /**
nit: we sort jsdoc parameters alphabetically, so it will be
- @param
- @return
- @template

[commit-bot: I haz the power, 2016-12-03 00:36:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-03 00:36:25]

Dry run: This issue passed the CQ dry run.

[allada, 2016-12-03 02:12:02]

done

https://codereview.chromium.org/2543633009/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/Target.js (right):

https://codereview.chromium.org/2543633009/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/Target.js:138: /**
On 2016/12/03 00:36:23, lushnikov wrote:
> nit: we sort jsdoc parameters alphabetically, so it will be
> - @param
> - @return
> - @template

Done.

[allada, 2016-12-03 02:12:15]

The CQ bit was checked by allada@chromium.org

[allada, 2016-12-03 02:12:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2543633009/#ps20001
(title: "fix")

[commit-bot: I haz the power, 2016-12-03 02:12:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-03 04:06:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480731135560470,
"parent_rev": "523f481c45c049e54f09327708ad157068ec8efa", "commit_rev":
"4e6931ad1c12788da8897fca5d30b9a7f695c9e0"}

[commit-bot: I haz the power, 2016-12-03 04:07:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-03 04:10:31]

Description was changed from

==========
[Devtools] Template fromTarget() function calls to model

This patch is for code health, it only modifies the JSDocs to add
template types to fromTarget calls on the SDKModels, so the developer
does not need to explicitly cast them.

R=lushnikov
BUG=None
==========

to

==========
[Devtools] Template fromTarget() function calls to model

This patch is for code health, it only modifies the JSDocs to add
template types to fromTarget calls on the SDKModels, so the developer
does not need to explicitly cast them.

R=lushnikov
BUG=None

Committed: https://crrev.com/df3a33988beebfe1b9341346e3437711622e5a83
Cr-Commit-Position: refs/heads/master@{#436164}
==========

[commit-bot: I haz the power, 2016-12-03 04:10:32]

Patchset 2 (id:??) landed as
https://crrev.com/df3a33988beebfe1b9341346e3437711622e5a83
Cr-Commit-Position: refs/heads/master@{#436164}