Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2543633006: To M56: Use ffmpeg for opus decoding, no need to maintain our decoder. (Closed)

Created:
4 years ago by wolenetz
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

To M56: Use ffmpeg for opus decoding, no need to maintain our decoder. As a bonus this allows WebAudio to start using opus. BUG=482934 TEST=all opus tests pass with the previous expectations. Review-Url: https://codereview.chromium.org/2435603009 Cr-Commit-Position: refs/heads/master@{#433433} (cherry picked from commit 655b0cf987eca28d8035cb3ceb1af6c4b916b179) TBR=dalecurtis@chromium.org,avi@chromium.org,alokp@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/a76943e15311ba010af0dec0df9b6c79e5532989

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -635 lines) Patch
M chromecast/media/cma/decoder/cast_audio_decoder_linux.cc View 2 chunks +2 lines, -28 lines 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M media/BUILD.gn View 3 chunks +4 lines, -4 lines 0 comments Download
M media/base/audio_discard_helper.h View 2 chunks +8 lines, -4 lines 0 comments Download
M media/base/audio_discard_helper.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M media/base/audio_discard_helper_unittest.cc View 15 chunks +15 lines, -15 lines 0 comments Download
M media/ffmpeg/ffmpeg_common.cc View 2 chunks +8 lines, -27 lines 0 comments Download
M media/ffmpeg/ffmpeg_common_unittest.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M media/filters/audio_decoder_unittest.cc View 9 chunks +20 lines, -74 lines 0 comments Download
M media/filters/ffmpeg_audio_decoder.cc View 3 chunks +10 lines, -15 lines 0 comments Download
D media/filters/opus_audio_decoder.h View 1 chunk +0 lines, -68 lines 0 comments Download
D media/filters/opus_audio_decoder.cc View 1 chunk +0 lines, -368 lines 0 comments Download
M media/renderers/default_renderer_factory.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M media/test/pipeline_integration_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/test/pipeline_integration_test_base.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
wolenetz
Committed patchset #1 (id:1) manually as a76943e15311ba010af0dec0df9b6c79e5532989.
4 years ago (2016-12-01 20:14:59 UTC) #2
alokp
4 years ago (2016-12-01 20:26:56 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698