exo: NV12 support for linux-buffer-params interface.

exo: NV12 support for linux-buffer-params interface.

So far the only client using linux-buffer-params interface has only been
wayland_motion_client that allocates only RGB buffers.

A new wayland test client that uses linux-buffer-params
and produces YUV formats is in the works.

This CL adds NV12 to linux-buffer-params. It additionally removes the
check that the fds coming from wayland are valid, since wayland guarantees
that already.

BUG=

Committed: https://crrev.com/d89189d4cb6762dcbd0e622f6473920408a30fc2
Cr-Commit-Position: refs/heads/master@{#437400}

[Daniele Castagna, 2016-11-30 22:38:14]

dcastagna@chromium.org changed reviewers:
+ hoegsberg@chromium.org, reveman@chromium.org

[Daniele Castagna, 2016-11-30 22:40:48]

ccing gurchetansingh@

[reveman, 2016-11-30 22:59:49]

https://codereview.chromium.org/2543633005/diff/1/components/exo/wayland/serv...
File components/exo/wayland/server.cc (right):

https://codereview.chromium.org/2543633005/diff/1/components/exo/wayland/serv...
components/exo/wayland/server.cc:700: if (!i) {
can we post an error or have buffer creation fail instead of silently trying to
create a buffer from just one of the fds?

[Daniele Castagna, 2016-11-30 23:31:02]

https://codereview.chromium.org/2543633005/diff/1/components/exo/wayland/serv...
File components/exo/wayland/server.cc (right):

https://codereview.chromium.org/2543633005/diff/1/components/exo/wayland/serv...
components/exo/wayland/server.cc:700: if (!i) {
On 2016/11/30 at 22:59:49, reveman wrote:
> can we post an error or have buffer creation fail instead of silently trying
to create a buffer from just one of the fds?

Done.

[Daniele Castagna, 2016-11-30 23:41:20]

On 2016/11/30 at 23:31:02, Daniele Castagna wrote:
>
https://codereview.chromium.org/2543633005/diff/1/components/exo/wayland/serv...
> File components/exo/wayland/server.cc (right):
> 
>
https://codereview.chromium.org/2543633005/diff/1/components/exo/wayland/serv...
> components/exo/wayland/server.cc:700: if (!i) {
> On 2016/11/30 at 22:59:49, reveman wrote:
> > can we post an error or have buffer creation fail instead of silently trying
to create a buffer from just one of the fds?
> 
> Done.

Reverted it since all fds passed via wayland have to be valid fds.

[Daniele Castagna, 2016-12-09 00:04:15]

Description was changed from

==========
exo: NV12 support for linux-buffer-params interface.

So far the only client using linux-buffer-params interface has only been
wayland_motion_client that allocates only RGB buffers.

A new wayland test client that uses linux-buffer-params and produces YUV
formats is in the work.

This CL adds NV12 to linux-buffer-params. It also makes sure only the
first plane fd is used, since Chromium doens't support importing
multiple-fds buffers yet.

BUG=b/32726875
==========

to

==========
exo: NV12 support for linux-buffer-params interface.

So far the only client using linux-buffer-params interface has only been
wayland_motion_client that allocates only RGB buffers.

A new wayland test client that uses linux-buffer-params and produces YUV
formats is in the work.

This CL adds NV12 to linux-buffer-params.

BUG=
==========

[Daniele Castagna, 2016-12-09 00:05:43]

Description was changed from

==========
exo: NV12 support for linux-buffer-params interface.

So far the only client using linux-buffer-params interface has only been
wayland_motion_client that allocates only RGB buffers.

A new wayland test client that uses linux-buffer-params and produces YUV
formats is in the work.

This CL adds NV12 to linux-buffer-params.

BUG=
==========

to

==========
exo: NV12 support for linux-buffer-params interface.

So far the only client using linux-buffer-params interface has only been
wayland_motion_client that allocates only RGB buffers.

A new wayland test client that uses linux-buffer-params and produces YUV
formats is in the work.

This CL adds NV12 to linux-buffer-params. It additionally removes the
check that the fds coming from wayland are valid, since wayland guarantees
that already.

BUG=
==========

[Daniele Castagna, 2016-12-09 00:08:08]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 00:08:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniele Castagna, 2016-12-09 00:09:47]

On 2016/11/30 at 23:41:20, Daniele Castagna wrote:
> On 2016/11/30 at 23:31:02, Daniele Castagna wrote:
> >
https://codereview.chromium.org/2543633005/diff/1/components/exo/wayland/serv...
> > File components/exo/wayland/server.cc (right):
> > 
> >
https://codereview.chromium.org/2543633005/diff/1/components/exo/wayland/serv...
> > components/exo/wayland/server.cc:700: if (!i) {
> > On 2016/11/30 at 22:59:49, reveman wrote:
> > > can we post an error or have buffer creation fail instead of silently
trying to create a buffer from just one of the fds?
> > 
> > Done.
> 
> Reverted it since all fds passed via wayland have to be valid fds.

As discussed, we want chrome/drivers to work with multiple fds.
The ugly TODO has been removed.

PTAL.

[reveman, 2016-12-09 00:19:16]

lgtm

[gurchetansingh, 2016-12-09 00:29:33]

Description was changed from

==========
exo: NV12 support for linux-buffer-params interface.

So far the only client using linux-buffer-params interface has only been
wayland_motion_client that allocates only RGB buffers.

A new wayland test client that uses linux-buffer-params and produces YUV
formats is in the work.

This CL adds NV12 to linux-buffer-params. It additionally removes the
check that the fds coming from wayland are valid, since wayland guarantees
that already.

BUG=
==========

to

==========
exo: NV12 support for linux-buffer-params interface.

So far the only client using linux-buffer-params interface has only been
wayland_motion_client that allocates only RGB buffers.

A new wayland test client that uses linux-buffer-params and produces YUV formats
is in the works.

This CL adds NV12 to linux-buffer-params. It additionally removes the
check that the fds coming from wayland are valid, since wayland guarantees
that already.

BUG=
==========

[gurchetansingh, 2016-12-09 00:29:57]

Description was changed from

==========
exo: NV12 support for linux-buffer-params interface.

So far the only client using linux-buffer-params interface has only been
wayland_motion_client that allocates only RGB buffers.

A new wayland test client that uses linux-buffer-params and produces YUV formats
is in the works.

This CL adds NV12 to linux-buffer-params. It additionally removes the
check that the fds coming from wayland are valid, since wayland guarantees
that already.

BUG=
==========

to

==========
exo: NV12 support for linux-buffer-params interface.

So far the only client using linux-buffer-params interface has only been
wayland_motion_client that allocates only RGB buffers.

A new wayland test client that uses linux-buffer-params 
and produces YUV formats is in the works.

This CL adds NV12 to linux-buffer-params. It additionally removes the
check that the fds coming from wayland are valid, since wayland guarantees
that already.

BUG=
==========

[gurchetansingh, 2016-12-09 00:30:12]

On 2016/11/30 22:40:48, Daniele Castagna wrote:
> ccing gurchetansingh@

lgtm

[commit-bot: I haz the power, 2016-12-09 00:55:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 00:55:47]

Dry run: This issue passed the CQ dry run.

[Daniele Castagna, 2016-12-09 00:56:07]

The CQ bit was checked by dcastagna@chromium.org

[commit-bot: I haz the power, 2016-12-09 00:56:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 01:14:58]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1481244967830500,
"parent_rev": "a88650ef94dbc65dbcaa770e93ab0e91f6064e5a", "commit_rev":
"06233593a6fbc228c768f58f0cdd58391dc6f8d6"}

[commit-bot: I haz the power, 2016-12-09 01:15:28]

Description was changed from

==========
exo: NV12 support for linux-buffer-params interface.

So far the only client using linux-buffer-params interface has only been
wayland_motion_client that allocates only RGB buffers.

A new wayland test client that uses linux-buffer-params 
and produces YUV formats is in the works.

This CL adds NV12 to linux-buffer-params. It additionally removes the
check that the fds coming from wayland are valid, since wayland guarantees
that already.

BUG=
==========

to

==========
exo: NV12 support for linux-buffer-params interface.

So far the only client using linux-buffer-params interface has only been
wayland_motion_client that allocates only RGB buffers.

A new wayland test client that uses linux-buffer-params 
and produces YUV formats is in the works.

This CL adds NV12 to linux-buffer-params. It additionally removes the
check that the fds coming from wayland are valid, since wayland guarantees
that already.

BUG=
==========

[commit-bot: I haz the power, 2016-12-09 01:15:29]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-12-09 01:17:44]

Description was changed from

==========
exo: NV12 support for linux-buffer-params interface.

So far the only client using linux-buffer-params interface has only been
wayland_motion_client that allocates only RGB buffers.

A new wayland test client that uses linux-buffer-params 
and produces YUV formats is in the works.

This CL adds NV12 to linux-buffer-params. It additionally removes the
check that the fds coming from wayland are valid, since wayland guarantees
that already.

BUG=
==========

to

==========
exo: NV12 support for linux-buffer-params interface.

So far the only client using linux-buffer-params interface has only been
wayland_motion_client that allocates only RGB buffers.

A new wayland test client that uses linux-buffer-params
and produces YUV formats is in the works.

This CL adds NV12 to linux-buffer-params. It additionally removes the
check that the fds coming from wayland are valid, since wayland guarantees
that already.

BUG=

Committed: https://crrev.com/d89189d4cb6762dcbd0e622f6473920408a30fc2
Cr-Commit-Position: refs/heads/master@{#437400}
==========

[commit-bot: I haz the power, 2016-12-09 01:17:47]

Patchset 6 (id:??) landed as
https://crrev.com/d89189d4cb6762dcbd0e622f6473920408a30fc2
Cr-Commit-Position: refs/heads/master@{#437400}