Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2543613002: Revert "Don't update TabSpecificContentSettings on same-page navigation" (Closed)

Created:
4 years ago by clamy
Modified:
4 years ago
CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org, raymes+watch_chromium.org, cbentzel+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Revert "Don't update TabSpecificContentSettings on same-page navigation" This reverts commit fadbabf762310ae5d44221c37929dbf4807f5fe9. Revert "Fix content settings's cookie code to work with PlzNavigate." This reverts commit 092d3be76da7c2aef6a84e2791b5818a06cb4689. BUG=667256

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -105 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 3 chunks +5 lines, -14 lines 0 comments Download
M chrome/browser/content_settings/content_settings_usages_state_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/content_settings/tab_specific_content_settings.h View 4 chunks +24 lines, -22 lines 0 comments Download
M chrome/browser/content_settings/tab_specific_content_settings.cc View 6 chunks +50 lines, -61 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 2 chunks +10 lines, -6 lines 0 comments Download
M components/content_settings/core/browser/content_settings_usages_state.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/content_settings/core/browser/content_settings_usages_state.cc View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
clamy
@bauerb, nasko, scottmg: PTAL. This is the revert of jam's CL and my fix on ...
4 years ago (2016-11-30 14:04:17 UTC) #3
Bernhard Bauer
4 years ago (2016-11-30 14:19:41 UTC) #4 
LGTM in case you want to land this (although I'd prefer the other CL).

Powered by Google App Engine
This is Rietveld 408576698