Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2543593003:
MD History: Add a keyboard shortcut to open grouped mode (Closed)
|
Created:
4 years ago by tsergeant Modified:
4 years ago Reviewers:
calamity CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD History: Add a keyboard shortcut to open grouped mode
Grouped mode is currently in active development for MD History, but it
is necessary to execute Javascript in Devtools to enable it. This adds
an obscure keyboard shortcut to the page which enables grouped mode,
simplifying debugging of this feature.
BUG=589357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/c53aaeebb844690c91fb28e8bbfff3d19a07c930
Cr-Commit-Position: refs/heads/master@{#435576}
Patch Set 1 #Patch Set 2 : Rebase #
Messages
Total messages: 18 (11 generated)
Description was changed from ========== MD History: Add a keyboard shortcut to open grouped mode Grouped mode is currently in active development for MD History, but it is necessary to execute Javascript in Devtools to enable it. This adds an obscure keyboard shortcut to the page which enables grouped mode, simplifying debugging of this feature. BUG=589357 ========== to ========== MD History: Add a keyboard shortcut to open grouped mode Grouped mode is currently in active development for MD History, but it is necessary to execute Javascript in Devtools to enable it. This adds an obscure keyboard shortcut to the page which enables grouped mode, simplifying debugging of this feature. BUG=589357 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run
tsergeant@chromium.org changed reviewers: + calamity@chromium.org
WDYT?
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by tsergeant@chromium.org
The CQ bit was checked by tsergeant@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for
chrome/browser/resources/md_history/app.vulcanized.html:
While running git apply --index -p1;
<stdin>:87: trailing whitespace.
<stdin>:97: trailing whitespace.
<stdin>:101: trailing whitespace.
--light-theme-secondary-color: #737373;
<stdin>:102: trailing whitespace.
--light-theme-disabled-color: #9b9b9b;
<stdin>:105: trailing whitespace.
error: patch failed:
chrome/browser/resources/md_history/app.vulcanized.html:41
error: chrome/browser/resources/md_history/app.vulcanized.html: patch does not
apply
Patch: chrome/browser/resources/md_history/app.vulcanized.html
Index: chrome/browser/resources/md_history/app.vulcanized.html
diff --git a/chrome/browser/resources/md_history/app.vulcanized.html
b/chrome/browser/resources/md_history/app.vulcanized.html
index
51da137342c308f5e05d7d8c6a77d3cb004d28fe..38a138019e73ebb928cc31bda0c8e6f67dedd651
100644
--- a/chrome/browser/resources/md_history/app.vulcanized.html
+++ b/chrome/browser/resources/md_history/app.vulcanized.html
@@ -41,9 +41,7 @@ subject to an additional IP rights grant found at
http://polymer.github.io/PATEN
-</head><body><div hidden="" by-vulcanize="">
-
-<dom-module id="iron-pages"
assetpath="chrome://resources/polymer/v1_0/iron-pages/" css-build="shadow">
+</head><body><div hidden="" by-vulcanize=""><dom-module id="iron-pages"
assetpath="chrome://resources/polymer/v1_0/iron-pages/" css-build="shadow">
<template>
<style scope="iron-pages">:host {
@@ -186,6 +184,8 @@ subject to an additional IP rights grant found at
http://polymer.github.io/PATEN
}
</style>
+
+
<dom-module id="iron-icon"
assetpath="chrome://resources/polymer/v1_0/iron-icon/" css-build="shadow">
<template>
<style scope="iron-icon">:host {
@@ -265,46 +265,6 @@ subject to an additional IP rights grant found at
http://polymer.github.io/PATEN
</template>
</dom-module>
<style is="custom-style" css-build="shadow">html {
- --primary-text-color: var(--light-theme-text-color);
- --primary-background-color: var(--light-theme-background-color);
- --secondary-text-color: var(--light-theme-secondary-color);
- --disabled-text-color: var(--light-theme-disabled-color);
- --divider-color: var(--light-theme-divider-color);
- --error-color: var(--paper-deep-orange-a700);
-
-
- --primary-color: var(--paper-indigo-500);
- --light-primary-color: var(--paper-indigo-100);
- --dark-primary-color: var(--paper-indigo-700);
-
- --accent-color: var(--paper-pink-a200);
- --light-accent-color: var(--paper-pink-a100);
- --dark-accent-color: var(--paper-pink-a400);
-
-
-
- --light-theme-background-color: #ffffff;
- --light-theme-base-color: #000000;
- --light-theme-text-color: var(--paper-grey-900);
- --light-theme-secondary-color: #737373;
- --light-theme-disabled-color: #9b9b9b;
- --light-theme-divider-color: #dbdbdb;
-
-
- --dark-theme-background-color: var(--paper-grey-900);
- --dark-theme-base-color: #ffffff;
- --dark-theme-text-color: #ffffff;
- --dark-theme-secondary-color: #bcbcbc;
- --dark-theme-disabled-color: #646464;
- --dark-theme-divider-color: #3c3c3c;
-
-
- --text-primary-color: var(--dark-theme-text-color);
- --default-primary-color: var(--primary-color);
-}
-
-</style>
-<style is="custom-style" css-build="shadow">html {
--google-red-100: #f4c7c3;
--google-red-300: #e67c73;
--google-red-500: #db4437;
@@ -619,6 +579,50 @@ subject to an additional IP rights grant found at
http://polymer.github.io/PATEN
}
</style>
+
+
+<style is="custom-style" css-build="shadow">html {
+ --primary-text-color: var(--light-theme-text-color);
+ --primary-background-color: var(--light-theme-background-color);
+ --secondary-text-color: var(--light-theme-secondary-color);
+ --disabled-text-color: var(--light-theme-disabled-color);
+ --divider-color: var(--light-theme-divider-color);
+ --error-color: var(--paper-deep-orange-a700);
+
+
+ --primary-color: var(--paper-indigo-500);
+ --light-primary-color: var(--paper-indigo-100);
+ --dark-primary-color: var(--paper-indigo-700);
+
+ --accent-color: var(--paper-pink-a200);
+ --light-accent-color: var(--paper-pink-a100);
+ --dark-accent-color: var(--paper-pink-a400);
+
+
+
+ --light-theme-background-color: #ffffff;
+ --light-theme-base-color: #000000;
+ --light-theme-text-color: var(--paper-grey-900);
+ --light-theme-secondary-color: #737373;
+ --light-theme-disabled-color: #9b9b9b;
+ --light-theme-divider-color: #dbdbdb;
+
+
+ --dark-theme-background-color: var(--paper-grey-900);
+ --dark-theme-base-color: #ffffff;
+ --dark-theme-text-color: #ffffff;
+ --dark-theme-secondary-color: #bcbcbc;
+ --dark-theme-disabled-color: #646464;
+ --dark-theme-divider-color: #3c3c3c;
+
+
+ --text-primary-color: var(--dark-theme-text-color);
+ --default-primary-color: var(--primary-color);
+}
+
+</style>
+
+
<dom-module id="paper-icon-button"
assetpath="chrome://resources/polymer/v1_0/paper-icon-button/"
css-build="shadow">
<template strip-whitespace="">
<style scope="paper-icon-button">:host {
@@ -648,12 +652,12 @@ subject to an additional IP rights grant found at
http://polymer.github.io/PATEN
}
:host #ink {
- color: var(--paper-icon-button-ink-color,var(--primary-text-color));
+ color: var(--paper-icon-button-ink-color,var(--primary-text-color));;
opacity: 0.6;
}
:host([disabled]) {
- color: var(--paper-icon-button-disabled-text,var(--disabled-text-color));
+ color: var(--paper-icon-button-disabled-text,var(--disabled-text-color));;
pointer-events: none;
cursor: auto;
@@ -762,23 +766,23 @@ to {
height: 100%;
opacity: 0;
white-space: nowrap;
- border-color: var(--paper-spinner-color,var(--google-blue-500));
+ border-color: var(--paper-spinner-color,var(--google-blue-500));;
}
.layer-1 {
- border-color: var(--paper-spinner-layer-1-color,var(--google-blue-500));
+ border-color: var(--paper-spinner-layer-1-color,var(--google-blue-500));;
}
.layer-2 {
- border-color: var(--paper-spinner-layer-2-color,var(--google-red-500));
+ border-color: var(--paper-spinner-layer-2-color,var(--google-red-500));;
}
.layer-3 {
- border-color: var(--paper-spinner-layer-3-color,var(--google-yellow-500));
+ border-color: var(--paper-spinner-layer-3-color,var(--google-yellow-500));;
}
.layer-4 {
- border-color: var(--paper-spinner-layer-4-color,var(--google-green-500));
+ border-color: var(--paper-spinner-layer-4-color,var(--google-green-500));;
}
.active .spinner-layer {
@@ -1246,6 +1250,8 @@ to {
</style>
</template>
</dom-module>
+
+
<dom-module id="paper-spinner-lite"
assetpath="chrome://resources/polymer/v1_0/paper-spinner/" css-build="shadow">
<template strip-whitespace="">
<style scope="paper-spinner-lite">:host {
@@ -1300,23 +1306,23 @@ to {
height: 100%;
opacity: 0;
white-space: nowrap;
- border-color: var(--paper-spinner-color,var(--google-blue-500));
+ border-color: var(--paper-spinner-color,var(--google-blue-500));;
}
.layer-1 {
- border-color: var(--paper-spinner-layer-1-color,var(--google-blue-500));
+ border-color: var(--paper-spinner-layer-1-color,var(--google-blue-500));;
}
.layer-2 {
- border-color: var(--paper-spinner-layer-2-color,var(--google-red-500));
+ border-color: var(--paper-spinner-layer-2-color,var(--google-red-500));;
}
.layer-3 {
- border-color: var(--paper-spinner-layer-3-color,var(--google-yellow-500));
+ border-color: var(--paper-spinner-layer-3-color,var(--google-yellow-500));;
}
.layer-4 {
- border-color: var(--paper-spinner-layer-4-color,var(--google-green-500));
+ border-color: var(--paper-spinner-layer-4-color,var(--google-green-500));;
}
.active .spinner-layer {
@@ -2195,6 +2201,8 @@ button.more-vert-button div {
</style>
</template>
</dom-module>
+
+
<dom-module id="history-toolbar" assetpath="chrome://history/"
css-build="shadow">
<template>
<style scope="history-toolbar">[hidden] {
@@ -2483,9 +2491,6 @@ paper-tabs {
</template>
</dom-module>
-
-
-
<style is="custom-style" css-build="shadow">html {
--cr-actionable_-_cursor: pointer;;
--cr-focused-item-color: var(--google-grey-300);
@@ -2495,6 +2500,7 @@ paper-tabs {
}
</style>
+
<dom-module id="cr-shared-style" assetpath="chrome://resources/cr_elements/"
css-build="shadow">
<template>
<style scope="cr-shared-style">paper-spinner {
@@ -2678,6 +2684,8 @@ paper-tabs {
<link rel="import" href="chrome://resources/html/util.html">
<dom-module id="history-searched-label" assetpath="chrome://history/"
css-build="shadow">
</dom-module>
+
+
<dom-module id="history-item" assetpath="chrome://history/" css-build="shadow">
<template>
<style scope="history-item">[hidden] {
@@ -3098,6 +3106,8 @@ iron-list {
</iron-scroll-threshold>
</template>
</dom-module>
+
+
<dom-module id="history-list-container" assetpath="chrome://history/"
css-build="shadow">
<template>
<style scope="history-list-container">[hidden] {
@@ -3307,6 +3317,38 @@ dialog .body {
</iron-query-params>
</template>
</dom-module>
+<style>
+/* Copyright 2015 The Chromium Authors. All rights reserved.
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file. */
+
+<if expr="not chromeos and not is_android">
+@font-face {
+ font-family: 'Roboto';
+ font-style: normal;
+ font-weight: 400;
+ src: local('Roboto'), local('Roboto-Regular'),
+ url("chrome://resources/roboto/roboto-regular.woff2") format('woff2');
+}
+
+@font-face {
+ font-family: 'Roboto';
+ font-style: normal;
+ font-weight: 500;
+ src: local('Roboto Medium'), local('Roboto-Medium'),
+ url("chrome://resources/roboto/roboto-medium…
(message too large)
The CQ bit was checked by tsergeant@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from calamity@chromium.org Link to the patchset: https://codereview.chromium.org/2543593003/#ps20001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480572367031950,
"parent_rev": "968c75ef5bfd07b7e2b9898cd543f48d3bd57605", "commit_rev":
"a5c41d58be747d20c7bbbdbfc62721e7e912eaf9"}
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== MD History: Add a keyboard shortcut to open grouped mode Grouped mode is currently in active development for MD History, but it is necessary to execute Javascript in Devtools to enable it. This adds an obscure keyboard shortcut to the page which enables grouped mode, simplifying debugging of this feature. BUG=589357 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD History: Add a keyboard shortcut to open grouped mode Grouped mode is currently in active development for MD History, but it is necessary to execute Javascript in Devtools to enable it. This adds an obscure keyboard shortcut to the page which enables grouped mode, simplifying debugging of this feature. BUG=589357 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/c53aaeebb844690c91fb28e8bbfff3d19a07c930 Cr-Commit-Position: refs/heads/master@{#435576} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c53aaeebb844690c91fb28e8bbfff3d19a07c930 Cr-Commit-Position: refs/heads/master@{#435576} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
