Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2543573003: [Android] Use BUNDLE and BUNDLE_ARRAY app restriction types (Closed)

Created:
4 years ago by aberent
Modified:
4 years ago
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Use BUNDLE and BUNDLE_ARRAY app restriction types From Android M app restrictions may contain bundles and arrays of bundles. Support this in Chrome. Convert them to JSON for transfer to the native side. BUG=525441 Committed: https://crrev.com/5102a7c160484c9878c2d73925f207374e6697a8 Cr-Commit-Position: refs/heads/master@{#436264}

Patch Set 1 #

Patch Set 2 : Change annotation order to satisfy JNI generator #

Total comments: 1

Patch Set 3 : Fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -8 lines) Patch
M components/policy/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/policy/android/java/src/org/chromium/policy/PolicyConverter.java View 1 2 4 chunks +81 lines, -8 lines 0 comments Download
A components/policy/android/junit/src/org/chromium/policy/PolicyConverterTest.java View 1 chunk +75 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
aberent
bauerb@ - Please review. pastarmovj@ - Please approve as OWNER (bauerb@ isn't an owner).
4 years ago (2016-11-30 18:50:28 UTC) #2
Bernhard Bauer
lgtm https://codereview.chromium.org/2543573003/diff/20001/components/policy/android/java/src/org/chromium/policy/PolicyConverter.java File components/policy/android/java/src/org/chromium/policy/PolicyConverter.java (right): https://codereview.chromium.org/2543573003/diff/20001/components/policy/android/java/src/org/chromium/policy/PolicyConverter.java#newcode76 components/policy/android/java/src/org/chromium/policy/PolicyConverter.java:76: // policy. Nit: move this to the previous ...
4 years ago (2016-12-01 23:25:02 UTC) #11
pastarmovj
owner's lgtm but totally relying on Bernhard for the approval as my Android-fu ist pretty ...
4 years ago (2016-12-02 08:13:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2543573003/40001
4 years ago (2016-12-05 11:12:16 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-05 12:03:45 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-05 12:06:17 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5102a7c160484c9878c2d73925f207374e6697a8
Cr-Commit-Position: refs/heads/master@{#436264}

Powered by Google App Engine
This is Rietveld 408576698