chrome/browser/safe_browsing/certificate_reporting_service_factory.cc - Issue 2543523002: Implement main CertificateReportingService code and add unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/certificate_reporting_service_factory.cc

Issue 2543523002: Implement main CertificateReportingService code and add unit tests. (Closed)

Patch Set: estark comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/certificate_reporting_service.cc ('k') | chrome/browser/safe_browsing/certificate_reporting_service_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/certificate_reporting_service_factory.cc

diff --git a/chrome/browser/safe_browsing/certificate_reporting_service_factory.cc b/chrome/browser/safe_browsing/certificate_reporting_service_factory.cc

index bed32fdb06b1b7fe9c513880f4fc3159504eeff4..fc1eab154ee65d1b082936cdde0f3e04c19357f8 100644

--- a/chrome/browser/safe_browsing/certificate_reporting_service_factory.cc

+++ b/chrome/browser/safe_browsing/certificate_reporting_service_factory.cc

@@ -29,7 +29,8 @@ CertificateReportingServiceFactory::~CertificateReportingServiceFactory() {}

KeyedService* CertificateReportingServiceFactory::BuildServiceInstanceFor(

content::BrowserContext* profile) const {

- return new CertificateReportingService();

+ // TODO(crbug.com/554323): Create a real CertificateReportingService here.

+ return nullptr;

}

content::BrowserContext*