Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(12)

Issue 2543503004: More fixes to the build instructions. (Closed)

Created:
3 years, 10 months ago by Dirk Pranke
Modified:
3 years, 10 months ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

More fixes to the build instructions. This picks up various fixes noted by scottmg@chromium.org, thakis@chromium.org, and Twitter user @florpelier, as well as a few more things I wanted to clean up. R=scottmg@chromium.org, thakis@chromium.org, sdy@chromium.org BUG= Committed: https://crrev.com/1a70d0c93ba16335dd77d947c2e9c6fd080977c4 Cr-Commit-Position: refs/heads/master@{#435533}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -34 lines) Patch
M docs/android_build_instructions.md View 2 chunks +9 lines, -2 lines 0 comments Download
M docs/get_the_code.md View 1 chunk +2 lines, -2 lines 0 comments Download
M docs/ios_build_instructions.md View 2 chunks +9 lines, -2 lines 0 comments Download
M docs/linux_build_instructions.md View 3 chunks +9 lines, -3 lines 0 comments Download
M docs/mac_build_instructions.md View 4 chunks +25 lines, -4 lines 0 comments Download
M docs/windows_build_instructions.md View 10 chunks +35 lines, -21 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Dirk Pranke
First to stamp wins? @scottmg - this folds in the changes from your patch.
3 years, 10 months ago (2016-12-01 02:13:30 UTC) #1
Sidney San Martín
lgtm
3 years, 10 months ago (2016-12-01 02:37:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2543503004/1
3 years, 10 months ago (2016-12-01 02:38:12 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 10 months ago (2016-12-01 02:43:03 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1a70d0c93ba16335dd77d947c2e9c6fd080977c4 Cr-Commit-Position: refs/heads/master@{#435533}
3 years, 10 months ago (2016-12-01 02:46:19 UTC) #12
scottmg
Oops, realized the system locale might still need to be changed until a few more ...
3 years, 10 months ago (2016-12-01 02:54:09 UTC) #13
Dirk Pranke
On 2016/12/01 02:54:09, scottmg wrote: > Oops, realized the system locale might still need to ...
3 years, 10 months ago (2016-12-01 02:55:45 UTC) #14
Nico
Trying to look at the instructions with the eye of a newcomer this morning, two ...
3 years, 10 months ago (2016-12-01 15:02:54 UTC) #15
Dirk Pranke
3 years, 10 months ago (2016-12-01 16:43:59 UTC) #16
Message was sent while issue was closed.
On 2016/12/01 15:02:54, Nico wrote:
> Trying to look at the instructions with the eye of a newcomer this morning,
two
> thoughts:
> 
> 1.) This is much better than what we had before, thanks for doing this.

Great!

> 2.) Can we remove the "look at the old instructions here" lines? They're
> confusing for most people, and the 3 folks who want to get to them can get
them
> from git history.

Yes, I mostly wanted to leave them in for a day or two in case I got things
horribly
wrong. I'll remove them today.

Powered by Google App Engine
This is Rietveld 408576698