Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2950)

Unified Diff: cc/layers/nine_patch_layer.h

Issue 2543473005: Draw omnibox shadow with a ninebox layer.
Patch Set: (not for commit --- added benchmarking code) Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/nine_patch_layer.h
diff --git a/cc/layers/nine_patch_layer.h b/cc/layers/nine_patch_layer.h
index cf9edf99c72c9f6102c73746d82fd94e8cb95f33..e5cf11ca5f6bbe4817243f105ddfea444a4e7f59 100644
--- a/cc/layers/nine_patch_layer.h
+++ b/cc/layers/nine_patch_layer.h
@@ -27,6 +27,9 @@ class CC_EXPORT NinePatchLayer : public UIResourceLayer {
// size of the left and top boundary, respectively.
// |border.width()-border.x()| and |border.height()-border.y()| are the size
// of the right and bottom boundary, respectively.
+ // TODO(estade): this really ought to be a gfx::Insets and not a gfx::Rect. To
+ // convert from rect to insets, think of x() as left(), y() as top(), width()
+ // - x() as right(), and height() - y() as bottom().
void SetBorder(const gfx::Rect& border);
// aperture is in the pixel space of the bitmap resource and refers to
« no previous file with comments | « no previous file | chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698