Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Side by Side Diff: cc/layers/render_surface_impl.cc

Issue 2543473004: cc: Move filters from RenderPassDrawQuad to RenderPass (Closed)
Patch Set: Address review comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/layers/render_surface_impl.h" 5 #include "cc/layers/render_surface_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 10
(...skipping 323 matching lines...) Expand 10 before | Expand all | Expand 10 after
334 DCHECK_GT(layer_id, 0); 334 DCHECK_GT(layer_id, 0);
335 return RenderPassId(layer_id, sub_id); 335 return RenderPassId(layer_id, sub_id);
336 } 336 }
337 337
338 void RenderSurfaceImpl::AppendRenderPasses(RenderPassSink* pass_sink) { 338 void RenderSurfaceImpl::AppendRenderPasses(RenderPassSink* pass_sink) {
339 std::unique_ptr<RenderPass> pass = RenderPass::Create(layer_list_.size()); 339 std::unique_ptr<RenderPass> pass = RenderPass::Create(layer_list_.size());
340 pass->SetNew(GetRenderPassId(), content_rect(), 340 pass->SetNew(GetRenderPassId(), content_rect(),
341 gfx::IntersectRects(content_rect(), 341 gfx::IntersectRects(content_rect(),
342 damage_tracker_->current_damage_rect()), 342 damage_tracker_->current_damage_rect()),
343 draw_properties_.screen_space_transform); 343 draw_properties_.screen_space_transform);
344 pass->filters = Filters();
345 pass->background_filters = BackgroundFilters();
344 pass_sink->AppendRenderPass(std::move(pass)); 346 pass_sink->AppendRenderPass(std::move(pass));
345 } 347 }
346 348
347 void RenderSurfaceImpl::AppendQuads(RenderPass* render_pass, 349 void RenderSurfaceImpl::AppendQuads(RenderPass* render_pass,
348 AppendQuadsData* append_quads_data) { 350 AppendQuadsData* append_quads_data) {
349 gfx::Rect visible_layer_rect = 351 gfx::Rect visible_layer_rect =
350 occlusion_in_content_space().GetUnoccludedContentRect(content_rect()); 352 occlusion_in_content_space().GetUnoccludedContentRect(content_rect());
351 if (visible_layer_rect.IsEmpty()) 353 if (visible_layer_rect.IsEmpty())
352 return; 354 return;
353 355
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
389 } 391 }
390 392
391 DCHECK(owning_layer_draw_transform.IsScale2d()); 393 DCHECK(owning_layer_draw_transform.IsScale2d());
392 gfx::Vector2dF owning_layer_to_target_scale = 394 gfx::Vector2dF owning_layer_to_target_scale =
393 owning_layer_draw_transform.Scale2d(); 395 owning_layer_draw_transform.Scale2d();
394 396
395 RenderPassDrawQuad* quad = 397 RenderPassDrawQuad* quad =
396 render_pass->CreateAndAppendDrawQuad<RenderPassDrawQuad>(); 398 render_pass->CreateAndAppendDrawQuad<RenderPassDrawQuad>();
397 quad->SetNew(shared_quad_state, content_rect(), visible_layer_rect, 399 quad->SetNew(shared_quad_state, content_rect(), visible_layer_rect,
398 GetRenderPassId(), mask_resource_id, mask_uv_scale, 400 GetRenderPassId(), mask_resource_id, mask_uv_scale,
399 mask_texture_size, Filters(), owning_layer_to_target_scale, 401 mask_texture_size, owning_layer_to_target_scale,
400 FiltersOrigin(), BackgroundFilters()); 402 FiltersOrigin());
401 } 403 }
402 404
403 } // namespace cc 405 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698