Add retrolambda.py and integrate it to build process.

Adds experimental support for Java 8 via gn arg

Requires host machines to have jdk8 installed and uses retrolambda to
convert java 8 .jar files into java 7 .jar files.

Future work includes adding Retrolambda into third_party libraries.

BUG=642600
Committed: https://crrev.com/d8c7a8acef06acc9f093177d568789f8f3329c23
Cr-Commit-Position: refs/heads/master@{#435629}

[F, 2016-11-30 15:28:09]

Description was changed from

==========
Add retrolambda.py and integrate it to build process.

BUG=
==========

to

==========
Add retrolambda.py and integrate it to build process. This is part of the effort
to add Java 1.8 support via Retrolambda. Future work includes adding Retrolambda
into third_party libraries.

BUG=642600
==========

[F, 2016-11-30 15:37:15]

Patchset #1 (id:1) has been deleted

[F, 2016-11-30 15:38:10]

The CQ bit was checked by zpeng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 15:38:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[F, 2016-11-30 15:38:37]

Hi Andrew, PTAL. Thanks!

[commit-bot: I haz the power, 2016-11-30 16:44:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 16:44:55]

Dry run: This issue passed the CQ dry run.

[F, 2016-11-30 21:29:11]

zpeng@chromium.org changed reviewers:
+ agrieve@chromium.org

[F, 2016-11-30 21:29:12]

Hi Andrew, PTAL. Thanks!

[agrieve, 2016-11-30 21:43:55]

Description was changed from

==========
Add retrolambda.py and integrate it to build process. This is part of the effort
to add Java 1.8 support via Retrolambda. Future work includes adding Retrolambda
into third_party libraries.

BUG=642600
==========

to

==========
Add retrolambda.py and integrate it to build process.

This is part of the effort to add Java 1.8 support via Retrolambda. Future work
includes adding Retrolambda into third_party libraries.

BUG=642600
==========

[agrieve, 2016-11-30 21:45:24]

Description was changed from

==========
Add retrolambda.py and integrate it to build process.

This is part of the effort to add Java 1.8 support via Retrolambda. Future work
includes adding Retrolambda into third_party libraries.

BUG=642600
==========

to

==========
Adds experimental support for Java 8 via gn arg

Requires host machines to have jdk8 installed and uses retrolambda to
convert java 8 .jar files into java 7 .jar files.

Future work includes adding Retrolambda into third_party libraries.

BUG=642600
==========

[agrieve, 2016-11-30 21:54:42]

just a couple nits. lgtm

https://codereview.chromium.org/2543463002/diff/20001/build/android/gyp/retro...
File build/android/gyp/retrolambda.py (right):

https://codereview.chromium.org/2543463002/diff/20001/build/android/gyp/retro...
build/android/gyp/retrolambda.py:29: ':'.join(classpath + [temp_dir,
android_sdk_jar]),
nit: This should probably actually be [temp_dir] + classpath + [android_sdk_jar]

https://codereview.chromium.org/2543463002/diff/20001/build/config/android/co...
File build/config/android/config.gni (right):

https://codereview.chromium.org/2543463002/diff/20001/build/config/android/co...
build/config/android/config.gni:150: # Enables java8 language features (via
retrolambda).
nit: please add "work-in-progress (http://crbug.com/642600)"

[F, 2016-12-01 15:09:51]

Thanks Andrew! Going to submit it soon

https://codereview.chromium.org/2543463002/diff/20001/build/android/gyp/retro...
File build/android/gyp/retrolambda.py (right):

https://codereview.chromium.org/2543463002/diff/20001/build/android/gyp/retro...
build/android/gyp/retrolambda.py:29: ':'.join(classpath + [temp_dir,
android_sdk_jar]),
On 2016/11/30 21:54:42, agrieve (OOO Dec 1) wrote:
> nit: This should probably actually be [temp_dir] + classpath +
[android_sdk_jar]

Done.

https://codereview.chromium.org/2543463002/diff/20001/build/config/android/co...
File build/config/android/config.gni (right):

https://codereview.chromium.org/2543463002/diff/20001/build/config/android/co...
build/config/android/config.gni:150: # Enables java8 language features (via
retrolambda).
On 2016/11/30 21:54:42, agrieve (OOO Dec 1) wrote:
> nit: please add "work-in-progress (http://crbug.com/642600)%22

Done.

[F, 2016-12-01 15:46:06]

The CQ bit was checked by zpeng@chromium.org

[F, 2016-12-01 15:46:06]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2543463002/#ps40001
(title: "Addressing comments")

[commit-bot: I haz the power, 2016-12-01 15:46:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 16:56:54]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480607166292170,
"parent_rev": "3006710f5b50082c0f29a7acefaaa798e97e9250", "commit_rev":
"aaa639d174b408789fb15714156f2e34beda8518"}

[commit-bot: I haz the power, 2016-12-01 16:57:26]

Description was changed from

==========
Adds experimental support for Java 8 via gn arg

Requires host machines to have jdk8 installed and uses retrolambda to
convert java 8 .jar files into java 7 .jar files.

Future work includes adding Retrolambda into third_party libraries.

BUG=642600
==========

to

==========
Adds experimental support for Java 8 via gn arg

Requires host machines to have jdk8 installed and uses retrolambda to
convert java 8 .jar files into java 7 .jar files.

Future work includes adding Retrolambda into third_party libraries.

BUG=642600
==========

[commit-bot: I haz the power, 2016-12-01 16:57:27]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-12-01 17:01:18]

Description was changed from

==========
Adds experimental support for Java 8 via gn arg

Requires host machines to have jdk8 installed and uses retrolambda to
convert java 8 .jar files into java 7 .jar files.

Future work includes adding Retrolambda into third_party libraries.

BUG=642600
==========

to

==========
Adds experimental support for Java 8 via gn arg

Requires host machines to have jdk8 installed and uses retrolambda to
convert java 8 .jar files into java 7 .jar files.

Future work includes adding Retrolambda into third_party libraries.

BUG=642600

Committed: https://crrev.com/d8c7a8acef06acc9f093177d568789f8f3329c23
Cr-Commit-Position: refs/heads/master@{#435629}
==========

[commit-bot: I haz the power, 2016-12-01 17:01:19]

Patchset 2 (id:??) landed as
https://crrev.com/d8c7a8acef06acc9f093177d568789f8f3329c23
Cr-Commit-Position: refs/heads/master@{#435629}