Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1136)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 25434004: Generate toCSSFooValue() for CSSCanvasValue, CSSCrossfadeValue, CSSImageGeneratorValue, CSSImageVal… (Closed)

Created:
7 years, 2 months ago by gyuyoung-inactive
Modified:
7 years, 2 months ago
Reviewers:
tkent
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Generate toCSSFooValue() for CSSFooValues As a step of generating toCSSFooValue(), this cl adds toCSSFooValue() for some CSS child values. (CSSCanvasValue, CSSCrossfadeValue, CSSImageGeneratorValue, CSSImageValue, CSSInitialValue, CSSTimingFunctionValue, CSSCubicBezierTimingFunctionValue and CSSStepsTimingFunctionValue) This will help to detect bad type casts. To support some toCSSFooValue(), isCanvasValue(), isUnicodeRangeValue(), and isCrossfadeValue() are addeded to CSSValue.h. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158916

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -38 lines) Patch
M Source/core/css/CSSCanvasValue.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSCrossfadeValue.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSCrossfadeValue.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSImageGeneratorValue.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSImageGeneratorValue.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/css/CSSImageValue.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/css/CSSInitialValue.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSTimingFunctionValue.h View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/core/css/CSSToStyleMap.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSUnicodeRangeValue.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSValue.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/css/CSSValue.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M Source/core/css/FontFace.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/ElementStyleResources.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/rendering/style/StylePendingImage.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
gyuyoung-inactive
Add tkent.
7 years, 2 months ago (2013-10-04 05:15:29 UTC) #1
tkent
lgtm
7 years, 2 months ago (2013-10-04 05:25:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/25434004/1
7 years, 2 months ago (2013-10-04 05:25:54 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-04 10:41:01 UTC) #4
Message was sent while issue was closed. 
Change committed as 158916

Powered by Google App Engine
This is Rietveld 408576698