content/browser/web_contents/render_view_host_manager.h - Issue 25434002: Don't leave renderer process frozen when canceling JavaScript dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/render_view_host_manager.h

Issue 25434002: Don't leave renderer process frozen when canceling JavaScript dialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove WebContentsObserver Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/render_view_host_manager.h

diff --git a/content/browser/web_contents/render_view_host_manager.h b/content/browser/web_contents/render_view_host_manager.h

index aacc90be81c6d206e7db972bd419bb0932b2ee8d..8f73610b4b573b9e9746e602d055ea1fd31e6eff 100644

--- a/content/browser/web_contents/render_view_host_manager.h

+++ b/content/browser/web_contents/render_view_host_manager.h

@@ -64,6 +64,7 @@ class CONTENT_EXPORT RenderViewHostManager

virtual void RenderProcessGoneFromRenderManager(

RenderViewHost* render_view_host) = 0;

virtual void UpdateRenderViewSizeForRenderManager() = 0;

+ virtual void CancelModalDialogsForRenderManager() = 0;

virtual void NotifySwappedFromRenderManager(

RenderViewHost* old_render_view_host) = 0;

virtual NavigationControllerImpl&