DevTools: omit remoteBase query param when starting a shared worker

third_party/WebKit/Source/devtools/front_end/services/ServiceManager.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 /**
  * @unrestricted
  */
 Services.ServiceManager = class {
   /**
    * @param {string} serviceName
    * @return {!Promise<?Services.ServiceManager.Service>}
@@ skipping 13 matching lines @@
 
   /**
    * @param {string} appName
    * @param {string} serviceName
    * @param {boolean} isSharedWorker
    * @return {!Promise<?Services.ServiceManager.Service>}
    */
   createAppService(appName, serviceName, isSharedWorker) {
     var url = appName + '.js';
     var remoteBase = Runtime.queryParam('remoteBase');
-    if (remoteBase)
+    // Do not pass additional query parameters to shared worker to avoid URLMismatchError
+    // in case another instance of DevTools with different remoteBase creates same shared worker.
+    if (remoteBase && !isSharedWorker)
       url += '?remoteBase=' + remoteBase;
 
     var worker = isSharedWorker ? new SharedWorker(url, appName) : new Worker(url);

[dgozman, 2016/12/02 19:55:53]

Should we instead pass different appName for different urls?

     var connection = new Services.ServiceManager.Connection(new Services.ServiceManager.WorkerServicePort(worker));
     return connection._createService(serviceName);
   }
 };
 
 /**
  * @unrestricted
  */
 Services.ServiceManager.Connection = class {
   /**
@@ skipping 318 matching lines @@
   close() {
     return this._workerPromise.then(() => {
       if (this._worker)
         this._worker.terminate();
       return false;
     });
   }
 };
 
 Services.serviceManager = new Services.ServiceManager();