base/file_util.cc - Issue 254333002: Make base::ReadFileToString() return false on I/O error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/file_util.cc

Issue 254333002: Make base::ReadFileToString() return false on I/O error. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix EXPECT_EQ() parameter order. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/file_util.cc

diff --git a/base/file_util.cc b/base/file_util.cc

index c1bf50abc45f720bca415d1bc56d5fb9bf35abda..d11cd15a2e0032d587329ab0399682c25b2195f4 100644

--- a/base/file_util.cc

+++ b/base/file_util.cc

@@ -157,6 +157,7 @@ bool ReadFileToString(const FilePath& path,

size += len;

}

+ read_status = read_status && !ferror(file);

CloseFile(file);

return read_status;

« no previous file with comments | « base/file_util.h ('k') | base/file_util_unittest.cc » ('j') | no next file with comments »