Make base::ReadFileToString() return false on I/O error.

base/file_util_unittest.cc

Index: base/file_util_unittest.cc
diff --git a/base/file_util_unittest.cc b/base/file_util_unittest.cc
index 0d793918d681fafeaa2e52a289cd4ebbb8a7e94d..7d9bc16ca562de10b558fd7aebc9a8e14cc8bab2 100644
--- a/base/file_util_unittest.cc
+++ b/base/file_util_unittest.cc
@@ -2012,7 +2012,12 @@ TEST_F(FileUtilTest, ReadFileToString) {
 
   FilePath file_path =
       temp_dir_.path().Append(FILE_PATH_LITERAL("ReadFileToStringTest"));
+  FilePath file_path_dangerous =
+      temp_dir_.path().Append(FILE_PATH_LITERAL("..")).
+      Append(temp_dir_.path().BaseName()).
+      Append(FILE_PATH_LITERAL("ReadFileToStringTest"));
 
+  // Create test file.
   ASSERT_EQ(4, WriteFile(file_path, kTestData, 4));
 
   EXPECT_TRUE(ReadFileToString(file_path, &data));
@@ -2042,6 +2047,11 @@ TEST_F(FileUtilTest, ReadFileToString) {
 
   EXPECT_TRUE(ReadFileToString(file_path, NULL));
 
+  data = "temp";
+  EXPECT_FALSE(ReadFileToString(file_path_dangerous, &data));
+  EXPECT_EQ(data.length(), 0u);

[willchan no longer on Chromium, 2014/04/30 15:14:40]

Ordering is (expected, actual), so 0u should go first. gTest uses this ordering
in its test output messages.

[Thiemo Nagel, 2014/04/30 16:11:33]

Thank you!  I was tricked into this by the surrounding code...

+
+  // Delete test file.
   EXPECT_TRUE(base::DeleteFile(file_path, false));
 
   data = "temp";