Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2543323003: DevTools: [SSP] make rule link to point to the style open bracket (Closed)

Created:
4 years ago by lushnikov
Modified:
4 years ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, tfarina, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [SSP] make rule link to point to the style open bracket Today, the rule link in Styles sidebar pane points to the first matching selector. However, due to malformed sourcemaps, this causes confusion. To avoid this, this patch points rule location to the opening curly brace of the style. It is still possible to ctrl-click on each individual selector to jump to its location. BUG=647785 R=dgozman Committed: https://crrev.com/403e1889da0385537fbe842cc0c436b33a94753a Cr-Commit-Position: refs/heads/master@{#436753}

Patch Set 1 #

Patch Set 2 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+306 lines, -309 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector-enabled/reattach-after-editing-styles-expected.txt View 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/elements/styles/edit-css-with-source-url-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/elements/styles/selector-line-deprecated-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/elements/styles/selector-line-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/elements/styles/selector-line-sourcemap-header-deprecated-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/elements/styles/selector-line-sourcemap-header-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/elements-panel-styles-expected.txt View 3 chunks +40 lines, -40 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-1/add-new-rule-with-style-after-body-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-1/color-aware-property-value-edit-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-1/commit-selector-expected.txt View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-1/commit-selector-mark-matching-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-1/css-live-edit-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-1/cssom-media-insert-crash-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-1/disable-property-workingcopy-update-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-1/dynamic-style-tag-expected.txt View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-1/edit-inspector-stylesheet-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-1/edit-media-text-expected.txt View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-1/edit-resource-referred-by-multiple-styletags-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-1/empty-background-url-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-2/add-import-rule-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-2/force-pseudo-state-expected.txt View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-2/inactive-properties-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-2/inherited-mixed-case-properties-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-2/inject-stylesheet-expected.txt View 4 chunks +22 lines, -22 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-2/keyframes-rules-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-2/lazy-computed-style-expected.txt View 4 chunks +20 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-2/media-emulation-expected.txt View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-2/media-queries-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-2/media-using-same-url-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-2/parse-comments-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-2/parse-utf8-bom-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-2/perform-undo-perform-of-mergable-action-expected.txt View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-2/pseudo-elements-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-2/region-style-crash-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-3/computed-properties-retain-expanded-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-3/selector-list-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-3/style-rule-from-imported-stylesheet-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-3/styles-add-new-rule-colon-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-3/styles-add-new-rule-expected.txt View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-3/styles-add-new-rule-tab-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-3/styles-add-new-rule-to-stylesheet-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-3/styles-computed-trace-expected.txt View 1 chunk +26 lines, -26 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-3/styles-disable-property-after-selector-edit-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-3/styles-variables-expected.txt View 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-4/inline-style-sourcemap-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-do-not-detach-sourcemap-on-edits-expected.txt View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-edit-property-after-invalid-rule-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-iframe-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-keyframes-expected.txt View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-overriden-properties-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-properties-overload-expected.txt View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-source-lines-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-source-lines-inline-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-source-lines-recovery-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-update-from-js-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-update-links-1-expected.txt View 2 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-update-links-2-expected.txt View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-update-links-3-expected.txt View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-update-links-4-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-with-spaces-in-sourceURL-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-4/svg-style-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-4/undo-add-new-rule-expected.txt View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-4/undo-add-property-expected.txt View 12 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles/cancel-upon-invalid-property-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles/undo-after-cancelled-editing-expected.txt View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles/undo-change-property-expected.txt View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles/undo-set-selector-text-expected.txt View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js View 1 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 25 (16 generated)
lushnikov
please, take a look
4 years ago (2016-12-03 00:49:54 UTC) #1
dgozman
lgtm
4 years ago (2016-12-04 03:16:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2543323003/1
4 years ago (2016-12-05 22:20:06 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/175177) android_cronet on master.tryserver.chromium.android (JOB_FAILED, ...
4 years ago (2016-12-05 22:25:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2543323003/20001
4 years ago (2016-12-06 06:03:50 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/350443)
4 years ago (2016-12-06 06:39:52 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2543323003/20001
4 years ago (2016-12-06 20:23:51 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-06 21:56:46 UTC) #23
commit-bot: I haz the power
4 years ago (2016-12-06 21:58:46 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/403e1889da0385537fbe842cc0c436b33a94753a
Cr-Commit-Position: refs/heads/master@{#436753}

Powered by Google App Engine
This is Rietveld 408576698