Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2543293002: Add virtual/spinvalidation/paint/invalidation test suite (Closed)

Created:
4 years ago by Xianzhu
Modified:
4 years ago
Reviewers:
chrishtr, pdr.
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add virtual/spinvalidation/paint/invalidation test suite This adds about 800 layout tests. Hopefully we'll enable SlimmingPaintInvalidation by default and remove this suite in a month. BUG=646176 Committed: https://crrev.com/1788fe21d26352d96d52821fbe9499352b68a78c Cr-Commit-Position: refs/heads/master@{#436400}

Patch Set 1 #

Patch Set 2 : - #

Patch Set 3 : - #

Patch Set 4 : - #

Patch Set 5 : Rebaseline-cl for eligible tests; Update TestExpectations #

Patch Set 6 : - #

Patch Set 7 : Rebaseline virtual/spinvalidation/paint/invalidation/select-option-background-color.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1184 lines, -7202 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=SlimmingPaintInvalidation View 1 2 1 chunk +2 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 5 4 chunks +15 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 chunk +5 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/flexbox/repaint-expected.txt View 1 2 1 chunk +0 lines, -155 lines 0 comments Download
D third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/flexbox/repaint-rtl-column-expected.txt View 1 2 1 chunk +0 lines, -79 lines 0 comments Download
D third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/line-flow-with-floats-4-expected.txt View 1 2 1 chunk +0 lines, -219 lines 0 comments Download
D third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/line-flow-with-floats-5-expected.txt View 1 2 1 chunk +0 lines, -238 lines 0 comments Download
D third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/outline-clip-change-expected.txt View 1 2 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/repaint-during-scroll-with-zoom-expected.txt View 1 2 1 chunk +0 lines, -87 lines 0 comments Download
D third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/scroll-in-transformed-layer-expected.txt View 1 2 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/scroll-with-transformed-parent-layer-expected.txt View 1 2 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/shift-relative-positioned-container-with-image-addition-expected.txt View 1 2 1 chunk +0 lines, -100 lines 0 comments Download
D third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/absolute-sized-document-no-scrollbars-expected.txt View 1 2 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/animated-path-inside-transformed-html-expected.txt View 1 2 1 chunk +0 lines, -80 lines 0 comments Download
D third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/deep-dynamic-updates-expected.txt View 1 2 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/js-late-gradient-and-object-creation-expected.txt View 1 2 1 chunk +0 lines, -122 lines 0 comments Download
D third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/js-late-marker-and-object-creation-expected.txt View 1 2 1 chunk +0 lines, -55 lines 0 comments Download
D third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/js-late-marker-creation-expected.txt View 1 2 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/js-late-pattern-and-object-creation-expected.txt View 1 2 1 chunk +0 lines, -146 lines 0 comments Download
D third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/js-update-bounce-expected.txt View 1 2 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/js-update-container-expected.txt View 1 2 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/js-update-polygon-changes-expected.txt View 1 2 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/js-update-polygon-removal-expected.txt View 1 2 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/js-update-transform-addition-expected.txt View 1 2 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/js-update-transform-changes-expected.txt View 1 2 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/paintorder-filtered-expected.txt View 1 2 1 chunk +0 lines, -127 lines 0 comments Download
D third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/relative-sized-content-with-resources-expected.txt View 1 2 1 chunk +0 lines, -56 lines 0 comments Download
D third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/repaint-paintorder-expected.txt View 1 2 1 chunk +0 lines, -105 lines 0 comments Download
D third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/stroke-opacity-update-expected.txt View 1 2 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/tabgroup-expected.txt View 1 2 1 chunk +0 lines, -1990 lines 0 comments Download
D third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/use-detach-expected.txt View 1 2 1 chunk +0 lines, -348 lines 0 comments Download
D third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/window-expected.txt View 1 2 1 chunk +0 lines, -2054 lines 0 comments Download
D third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/window-resize-percent-html-expected.txt View 1 2 1 chunk +0 lines, -129 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/virtual/spinvalidation/paint/invalidation/flexbox/repaint-expected.txt View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/virtual/spinvalidation/paint/invalidation/line-flow-with-floats-4-expected.txt View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/virtual/spinvalidation/paint/invalidation/line-flow-with-floats-5-expected.txt View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/virtual/spinvalidation/paint/invalidation/outline-clip-change-expected.txt View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/virtual/spinvalidation/paint/invalidation/repaint-during-scroll-with-zoom-expected.txt View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/virtual/spinvalidation/paint/invalidation/shift-relative-positioned-container-with-image-addition-expected.txt View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/virtual/spinvalidation/paint/invalidation/svg/animated-path-inside-transformed-html-expected.txt View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/virtual/spinvalidation/paint/invalidation/svg/js-late-gradient-and-object-creation-expected.txt View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/spinvalidation/paint/invalidation/svg/js-late-gradient-creation-expected.txt View 1 2 3 4 5 1 chunk +53 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/virtual/spinvalidation/paint/invalidation/svg/js-late-pattern-and-object-creation-expected.txt View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/virtual/spinvalidation/paint/invalidation/svg/relative-sized-content-with-resources-expected.txt View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/virtual/spinvalidation/paint/invalidation/svg/tabgroup-expected.txt View 1 2 3 4 6 chunks +45 lines, -45 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/virtual/spinvalidation/paint/invalidation/svg/use-detach-expected.txt View 1 2 3 4 5 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/spinvalidation/paint/invalidation/transform-inline-layered-child-expected.txt View 1 2 3 4 1 chunk +132 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/spinvalidation/paint/invalidation/select-option-background-color-expected.txt View 1 2 3 4 5 6 2 chunks +7 lines, -3 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/virtual/spinvalidation/paint/invalidation/flexbox/repaint-expected.txt View 1 2 3 4 3 chunks +41 lines, -22 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/virtual/spinvalidation/paint/invalidation/line-flow-with-floats-4-expected.txt View 1 2 3 4 8 chunks +33 lines, -33 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/virtual/spinvalidation/paint/invalidation/line-flow-with-floats-5-expected.txt View 1 2 3 4 7 chunks +31 lines, -40 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/virtual/spinvalidation/paint/invalidation/outline-clip-change-expected.txt View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/virtual/spinvalidation/paint/invalidation/repaint-during-scroll-with-zoom-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/virtual/spinvalidation/paint/invalidation/select-option-background-color-expected.txt View 1 2 3 4 5 6 2 chunks +7 lines, -3 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/virtual/spinvalidation/paint/invalidation/svg/animated-path-inside-transformed-html-expected.txt View 1 2 3 4 1 chunk +8 lines, -8 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/virtual/spinvalidation/paint/invalidation/svg/js-late-gradient-and-object-creation-expected.txt View 1 2 3 4 1 chunk +7 lines, -7 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/virtual/spinvalidation/paint/invalidation/svg/js-late-pattern-and-object-creation-expected.txt View 1 2 3 4 1 chunk +7 lines, -7 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/virtual/spinvalidation/paint/invalidation/svg/tabgroup-expected.txt View 1 2 3 4 5 chunks +175 lines, -175 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/virtual/spinvalidation/paint/invalidation/svg/window-expected.txt View 1 2 3 4 8 chunks +92 lines, -92 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/spinvalidation/paint/invalidation/transform-inline-layered-child-expected.txt View 1 2 3 4 1 chunk +132 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/virtual/spinvalidation/paint/invalidation/flexbox/repaint-expected.txt View 1 2 3 4 3 chunks +41 lines, -22 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/virtual/spinvalidation/paint/invalidation/line-flow-with-floats-4-expected.txt View 1 2 3 4 8 chunks +33 lines, -33 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/virtual/spinvalidation/paint/invalidation/line-flow-with-floats-5-expected.txt View 1 2 3 4 7 chunks +31 lines, -40 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/virtual/spinvalidation/paint/invalidation/outline-clip-change-expected.txt View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/virtual/spinvalidation/paint/invalidation/repaint-during-scroll-with-zoom-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/virtual/spinvalidation/paint/invalidation/svg/animated-path-inside-transformed-html-expected.txt View 1 2 3 4 1 chunk +8 lines, -8 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/virtual/spinvalidation/paint/invalidation/svg/js-late-gradient-and-object-creation-expected.txt View 1 2 3 4 1 chunk +7 lines, -7 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/virtual/spinvalidation/paint/invalidation/svg/js-late-gradient-creation-expected.txt View 1 2 3 4 5 1 chunk +53 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/virtual/spinvalidation/paint/invalidation/svg/js-late-pattern-and-object-creation-expected.txt View 1 2 3 4 1 chunk +7 lines, -7 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/virtual/spinvalidation/paint/invalidation/svg/tabgroup-expected.txt View 1 2 3 4 7 chunks +57 lines, -57 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/virtual/spinvalidation/paint/invalidation/svg/use-detach-expected.txt View 1 2 3 4 5 1 chunk +18 lines, -18 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/virtual/spinvalidation/paint/invalidation/transform-inline-layered-child-expected.txt View 1 2 3 4 1 chunk +132 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/spinvalidation/paint/invalidation/README.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/spinvalidation/paint/invalidation/flexbox/repaint-rtl-column-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/spinvalidation/paint/invalidation/scroll-in-transformed-layer-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/spinvalidation/paint/invalidation/scroll-with-transformed-parent-layer-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/spinvalidation/paint/invalidation/shift-relative-positioned-container-with-image-addition-expected.txt View 1 2 3 4 1 chunk +10 lines, -10 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/spinvalidation/paint/invalidation/svg/absolute-sized-document-no-scrollbars-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/spinvalidation/paint/invalidation/svg/deep-dynamic-updates-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/spinvalidation/paint/invalidation/svg/js-late-marker-and-object-creation-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/spinvalidation/paint/invalidation/svg/js-late-marker-creation-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/spinvalidation/paint/invalidation/svg/js-update-bounce-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/spinvalidation/paint/invalidation/svg/js-update-container-expected.txt View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/spinvalidation/paint/invalidation/svg/js-update-polygon-changes-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/spinvalidation/paint/invalidation/svg/js-update-polygon-removal-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/spinvalidation/paint/invalidation/svg/js-update-transform-addition-expected.txt View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/spinvalidation/paint/invalidation/svg/js-update-transform-changes-expected.txt View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/spinvalidation/paint/invalidation/svg/paintorder-filtered-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/spinvalidation/paint/invalidation/svg/relative-sized-content-with-resources-expected.txt View 1 2 3 4 1 chunk +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/spinvalidation/paint/invalidation/svg/repaint-paintorder-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/spinvalidation/paint/invalidation/svg/stroke-opacity-update-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/spinvalidation/paint/invalidation/svg/use-detach-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/spinvalidation/paint/invalidation/svg/window-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/spinvalidation/paint/invalidation/window-resize-percent-html-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 28 (23 generated)
Xianzhu
4 years ago (2016-12-05 17:51:33 UTC) #20
chrishtr
lgtm
4 years ago (2016-12-05 18:37:01 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2543293002/110001
4 years ago (2016-12-05 19:03:11 UTC) #24
commit-bot: I haz the power
Committed patchset #7 (id:110001)
4 years ago (2016-12-05 21:07:00 UTC) #26
commit-bot: I haz the power
4 years ago (2016-12-05 21:09:28 UTC) #28
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/1788fe21d26352d96d52821fbe9499352b68a78c
Cr-Commit-Position: refs/heads/master@{#436400}

Powered by Google App Engine
This is Rietveld 408576698