Use Map(s) for top-level declarations.

Use Map(s) for top-level declarations.

This would help to implement 'get sources by name' that Paul pointed
out in a previous CL.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/d6e89bf3a2245184f7660c8396c33aae2201b9e6

[Brian Wilkerson, 2016-12-02 16:32:17]

lgtm

https://codereview.chromium.org/2543263002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/file_state.dart (right):

https://codereview.chromium.org/2543263002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/file_state.dart:161: if
(!declarations.containsKey(t.name) &&
Somewhat off topic, but if we append the exported declarations before the
library declarations, then we don't need to test whether the name is already
defined.

[Paul Berry, 2016-12-02 16:34:42]

lgtm

https://codereview.chromium.org/2543263002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/file_state.dart (right):

https://codereview.chromium.org/2543263002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/file_state.dart:136: * Return
[TopLevelDeclaration]s exported from the this library file.
Can you update this comment to explain that the keys to the map are the
declaration names?

https://codereview.chromium.org/2543263002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/file_state.dart:223: * Return public
top-level declarations declared in the file.
Ditto

[scheglov, 2016-12-02 16:44:35]

Description was changed from

==========
Use Map(s) for top-level declarations.

This would help to implement 'get sources by name' that Paul pointed
out in a previous CL.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Use Map(s) for top-level declarations.

This would help to implement 'get sources by name' that Paul pointed
out in a previous CL.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/d6e89bf3a2245184f7660c8396c33aae2201b9e6
==========

[scheglov, 2016-12-02 16:44:37]

Committed patchset #1 (id:1) manually as
d6e89bf3a2245184f7660c8396c33aae2201b9e6 (presubmit successful).