Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 2543173002: Preparation CL for WebRTC performance test using promise-based getStats (Closed)

Created:
4 years ago by hbos_chromium
Modified:
4 years ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, phoglund+watch_chromium.org, mcasas+watch+vc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Preparation CL for WebRTC performance test using promise-based getStats Re-land of https://codereview.chromium.org/2534633002/ In order to have a perf test looking at stats of interest we need to be able to get the results of a JavaScript getStats call. These can be returned as JSON-stringified JavaScript dictionaries. In this CL: - [g|G]etStatsReportDictionary added to webrtc_browsertest_base.cc and peerconnection_getstats.js, which produce/read a JSON-stringified version of the stats. - RTCStatsReportDictionary and RTCStatsDictionary, helper classes for reading stats from the base::Dictionary representation of the stats. - Unittests for the helper classes. In a follow-up CL these methods/classes will be used to obtain the stats in the to-be-added performance test. This will yield pretty graphs. BUG=670306, 627816 Committed: https://crrev.com/4f0df039e3c3e854d5a527744e7855b09b4add67 Cr-Commit-Position: refs/heads/master@{#436252}

Patch Set 1 : Original CL #

Patch Set 2 : CHECK instead of DCHECK so that GetBlah code is run regardless of build settings #

Total comments: 2

Patch Set 3 : Using raw string literals #

Unified diffs Side-by-side diffs Delta from patch set Stats (+516 lines, -0 lines) Patch
A chrome/browser/media/webrtc/test_stats_dictionary.h View 1 chunk +85 lines, -0 lines 0 comments Download
A chrome/browser/media/webrtc/test_stats_dictionary.cc View 1 1 chunk +216 lines, -0 lines 0 comments Download
A chrome/browser/media/webrtc/test_stats_dictionary_unittest.cc View 1 2 1 chunk +167 lines, -0 lines 0 comments Download
M chrome/browser/media/webrtc/webrtc_browsertest_base.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/media/webrtc/webrtc_browsertest_base.cc View 1 2 chunks +17 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/data/webrtc/peerconnection_getstats.js View 1 chunk +23 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (9 generated)
hbos_chromium
Please take another look (reland), phoglund, hta and tommi
4 years ago (2016-12-02 11:00:55 UTC) #2
tommi (sloooow) - chröme
lgtm https://codereview.chromium.org/2543173002/diff/20001/chrome/browser/media/webrtc/test_stats_dictionary_unittest.cc File chrome/browser/media/webrtc/test_stats_dictionary_unittest.cc (right): https://codereview.chromium.org/2543173002/diff/20001/chrome/browser/media/webrtc/test_stats_dictionary_unittest.cc#newcode22 chrome/browser/media/webrtc/test_stats_dictionary_unittest.cc:22: const char kTestStatsReportJson[] = FYI - check out ...
4 years ago (2016-12-02 13:18:45 UTC) #7
phoglund_chromium
lgtm
4 years ago (2016-12-02 15:50:03 UTC) #8
hta - Chromium
lgtm
4 years ago (2016-12-04 22:42:49 UTC) #9
hbos_chromium
https://codereview.chromium.org/2543173002/diff/20001/chrome/browser/media/webrtc/test_stats_dictionary_unittest.cc File chrome/browser/media/webrtc/test_stats_dictionary_unittest.cc (right): https://codereview.chromium.org/2543173002/diff/20001/chrome/browser/media/webrtc/test_stats_dictionary_unittest.cc#newcode22 chrome/browser/media/webrtc/test_stats_dictionary_unittest.cc:22: const char kTestStatsReportJson[] = On 2016/12/02 13:18:44, tommi (chrömium) ...
4 years ago (2016-12-05 09:06:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2543173002/40001
4 years ago (2016-12-05 09:07:27 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-05 10:12:15 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-05 10:13:51 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4f0df039e3c3e854d5a527744e7855b09b4add67
Cr-Commit-Position: refs/heads/master@{#436252}

Powered by Google App Engine
This is Rietveld 408576698