Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 254313002: Add devtools trace events for Timeline EmbedderCallback notification (Closed)

Created:
6 years, 7 months ago by yurys
Modified:
6 years, 7 months ago
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, android-webview-reviews_chromium.org, pfeldman
Visibility:
Public.

Description

Add devtools trace events for Timeline EmbedderCallback notification This events will be used instead of existing implementation in InspectorTimelineAgent.cpp after switching Timeline to trace events as backend. BUG=361045 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268152

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M android_webview/common/devtools_instrumentation.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
yurys
6 years, 7 months ago (2014-04-30 14:14:21 UTC) #1
pfeldman
lgtm
6 years, 7 months ago (2014-04-30 14:15:34 UTC) #2
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 7 months ago (2014-04-30 14:29:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/254313002/1
6 years, 7 months ago (2014-04-30 14:29:50 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 14:41:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-04-30 14:41:33 UTC) #6
yurys
@benm: please do OWNERS review
6 years, 7 months ago (2014-04-30 14:42:16 UTC) #7
mnaganov (inactive)
LGTM
6 years, 7 months ago (2014-04-30 16:25:36 UTC) #8
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 7 months ago (2014-05-05 06:06:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/254313002/1
6 years, 7 months ago (2014-05-05 06:06:17 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-05 07:23:44 UTC) #11
Message was sent while issue was closed. 
Change committed as 268152

Powered by Google App Engine
This is Rietveld 408576698