Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2543123004: Mus: Move creation of cc::Display to DisplayCompositor (Closed)

Created:
4 years ago by Fady Samuel
Modified:
4 years ago
Reviewers:
kylechar
CC:
chromium-reviews, rjkroege
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mus: Move creation of cc::Display to DisplayCompositor What type of ContextProvider, and OutputSurface we create is a display- compositor-specific detail and not a CompositorFrameSink specific detail. A top-level GpuCompositorFrameSink needs a cc::Display to update the display's surface, but it doesn't need to know how the cc::Display was set up. This CL moves cc::Display creation to DisplayCompositor and passes in a unique_ptr to GpuCompositorFrameSink. That way, GpuCompositorFrameSink becomes a generic implementation that doesn't care whether an InProcessContextProvider or some other ContextProvider was used. This will allow this code to be reused elsewhere in Chrome. BUG=668126 Committed: https://crrev.com/64d953d2dbde0507b1ac81ce4768911cd870366d Cr-Commit-Position: refs/heads/master@{#436023}

Patch Set 1 #

Patch Set 2 : More cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -96 lines) Patch
M services/ui/surfaces/display_compositor.h View 4 chunks +16 lines, -8 lines 0 comments Download
M services/ui/surfaces/display_compositor.cc View 4 chunks +64 lines, -10 lines 0 comments Download
M services/ui/surfaces/gpu_compositor_frame_sink.h View 1 5 chunks +4 lines, -19 lines 0 comments Download
M services/ui/surfaces/gpu_compositor_frame_sink.cc View 3 chunks +6 lines, -59 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Fady Samuel
4 years ago (2016-12-02 19:01:16 UTC) #3
Fady Samuel
PTAL! Net negative LoC! w00t!
4 years ago (2016-12-02 19:11:00 UTC) #5
kylechar
lgtm
4 years ago (2016-12-02 19:56:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2543123004/20001
4 years ago (2016-12-02 19:58:12 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-02 21:19:13 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-02 21:22:16 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/64d953d2dbde0507b1ac81ce4768911cd870366d
Cr-Commit-Position: refs/heads/master@{#436023}

Powered by Google App Engine
This is Rietveld 408576698