[Devtools] Fixed frontend to properly support optional requestWillBeSent

[Devtools] Fixed frontend to properly support optional requestWillBeSent

requestWillBeSent protocol has an optional flag of "resourceType",
however our frontend will error if it does not have it set.

R=dgozman,lushnikov,caseq
BUG=653138
Committed: https://crrev.com/5a62ae3579981406e5e03ef55e5aa61b1d45bf27
Cr-Commit-Position: refs/heads/master@{#435849}

[lushnikov, 2016-12-02 01:52:23]

lgtm

https://codereview.chromium.org/2543113002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js (right):

https://codereview.chromium.org/2543113002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js:329:
networkRequest.setResourceType(Common.resourceTypes[resourceType] ||
Protocol.Page.ResourceType.Other);
nit: it's a bit hacky to query map with the undefined value. Let's rather:

resourceType ? Common.resourceTypes[resourceType] :
Protocol.Page.ResourceType.Other;

[allada, 2016-12-02 02:33:51]

done

https://codereview.chromium.org/2543113002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js (right):

https://codereview.chromium.org/2543113002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js:329:
networkRequest.setResourceType(Common.resourceTypes[resourceType] ||
Protocol.Page.ResourceType.Other);
On 2016/12/02 01:52:23, lushnikov wrote:
> nit: it's a bit hacky to query map with the undefined value. Let's rather:
> 
> resourceType ? Common.resourceTypes[resourceType] :
> Protocol.Page.ResourceType.Other;

Done.

[allada, 2016-12-02 02:33:58]

The CQ bit was checked by allada@chromium.org

[allada, 2016-12-02 02:33:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2543113002/#ps20001
(title: "[Devtools] Fixed frontend to properly support optional
requestWillBeSent")

[commit-bot: I haz the power, 2016-12-02 02:34:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 03:59:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480646038658590,
"parent_rev": "f4eb2bb1c4e4aa3ba84a0aec41f79f138123206b", "commit_rev":
"1b4454ab85eb45f38b558aa65fd158a61b77bf02"}

[commit-bot: I haz the power, 2016-12-02 04:00:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-02 04:03:17]

Description was changed from

==========
[Devtools] Fixed frontend to properly support optional requestWillBeSent

requestWillBeSent protocol has an optional flag of "resourceType",
however our frontend will error if it does not have it set.

R=dgozman,lushnikov,caseq
BUG=653138
==========

to

==========
[Devtools] Fixed frontend to properly support optional requestWillBeSent

requestWillBeSent protocol has an optional flag of "resourceType",
however our frontend will error if it does not have it set.

R=dgozman,lushnikov,caseq
BUG=653138

Committed: https://crrev.com/5a62ae3579981406e5e03ef55e5aa61b1d45bf27
Cr-Commit-Position: refs/heads/master@{#435849}
==========

[commit-bot: I haz the power, 2016-12-02 04:03:18]

Patchset 2 (id:??) landed as
https://crrev.com/5a62ae3579981406e5e03ef55e5aa61b1d45bf27
Cr-Commit-Position: refs/heads/master@{#435849}