Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: components/offline_pages/background/request_coordinator_unittest.cc

Issue 2543093002: Split the RequestPicker task into two separate tasks. (Closed)
Patch Set: ADD TODO Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_coordinator_unittest.cc
diff --git a/components/offline_pages/background/request_coordinator_unittest.cc b/components/offline_pages/background/request_coordinator_unittest.cc
index c35286321d05653b72932a395f8a97efe27b88b3..1b3bc8ec072b49f583f7f6415a03aa739e040a41 100644
--- a/components/offline_pages/background/request_coordinator_unittest.cc
+++ b/components/offline_pages/background/request_coordinator_unittest.cc
@@ -26,7 +26,6 @@
#include "components/offline_pages/background/offliner_factory_stub.h"
#include "components/offline_pages/background/offliner_policy.h"
#include "components/offline_pages/background/offliner_stub.h"
-#include "components/offline_pages/background/pick_request_task_factory.h"
#include "components/offline_pages/background/request_queue.h"
#include "components/offline_pages/background/request_queue_in_memory_store.h"
#include "components/offline_pages/background/save_page_request.h"
@@ -232,7 +231,7 @@ class RequestCoordinatorTest
else
coordinator_->disabled_requests_.clear();
- coordinator_->RequestNotPicked(non_user_requested_tasks_remaining);
+ coordinator_->RequestNotPicked(non_user_requested_tasks_remaining, false);
}
void SetDeviceConditionsForTest(DeviceConditions device_conditions) {
@@ -326,12 +325,6 @@ void RequestCoordinatorTest::SetUp() {
std::move(scheduler_stub), network_quality_estimator_.get()));
coordinator_->AddObserver(&observer_);
SetNetworkConnected(true);
- std::unique_ptr<PickRequestTaskFactory> picker_factory(
- new PickRequestTaskFactory(
- coordinator_->policy(),
- static_cast<RequestNotifier*>(coordinator_.get()),
- coordinator_->GetLogger()));
- coordinator_->queue()->SetPickerFactory(std::move(picker_factory));
immediate_callback_ =
base::Bind(&RequestCoordinatorTest::ImmediateScheduleCallbackFunction,
base::Unretained(this));
« no previous file with comments | « components/offline_pages/background/request_coordinator.cc ('k') | components/offline_pages/background/request_queue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698