Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: components/offline_pages/background/request_coordinator.h

Issue 2543093002: Split the RequestPicker task into two separate tasks. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_coordinator.h
diff --git a/components/offline_pages/background/request_coordinator.h b/components/offline_pages/background/request_coordinator.h
index c2d26b77d5fa1249cfcf5d72c3c8fd641b00e66c..f52260c3b26e69f34b2308c591cd7f42ef3c82f5 100644
--- a/components/offline_pages/background/request_coordinator.h
+++ b/components/offline_pages/background/request_coordinator.h
@@ -260,12 +260,13 @@ class RequestCoordinator : public KeyedService,
void ScheduleAsNeeded();
// Callback from the request picker when it has chosen our next request.
- void RequestPicked(const SavePageRequest& request);
+ void RequestPicked(const SavePageRequest& request, const bool cleanup_needed);
// Callback from the request picker when no more requests are in the queue.
// The parameter is a signal for what (if any) conditions to schedule future
// processing for.
- void RequestNotPicked(bool non_user_requested_tasks_remaining);
+ void RequestNotPicked(const bool non_user_requested_tasks_remaining,
fgorski 2016/12/02 21:44:04 I don't think you need to define "const bool" here
Pete Williamson 2016/12/05 20:39:46 Done.
+ const bool cleanup_needed);
// Callback from request picker that receives the current available queued
// request count as well as the total queued request count (which may be

Powered by Google App Engine
This is Rietveld 408576698