Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 2543073004: Manually rebaseline some paint/invalidation tests (Closed)

Created:
4 years ago by Xianzhu
Modified:
4 years ago
Reviewers:
wkorman
CC:
blink-reviews, chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Manually rebaseline some paint/invalidation tests For bug 636271, rebaseline the test to produce new format, but still keep the failure line in case it's still flaky. For bug 658605, NeedsRebaseline didn't work because of bug 660580. Manually rebaseline it to ensure test coverage. BUG=636271, 658605 Committed: https://crrev.com/3bc6c4619f272fb08cb4ca1520b4f20bf2cd9ee8 Cr-Commit-Position: refs/heads/master@{#436047}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -340 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 2 chunks +1 line, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/flexbox/scrollbars-changed-expected.txt View 2 chunks +15 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/multicol-repaint-expected.txt View 3 chunks +46 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/resize-iframe-text-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/resize-iframe-text-expected.txt View 4 chunks +2 lines, -44 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.10/paint/invalidation/resize-iframe-text-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.10/paint/invalidation/resize-iframe-text-expected.txt View 1 chunk +0 lines, -110 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/resize-iframe-text-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/resize-iframe-text-expected.txt View 5 chunks +2 lines, -36 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-retina/paint/invalidation/resize-iframe-text-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-retina/paint/invalidation/resize-iframe-text-expected.txt View 4 chunks +2 lines, -44 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/multicol-repaint-expected.txt View 3 chunks +46 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/resize-iframe-text-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/resize-iframe-text-expected.txt View 5 chunks +2 lines, -36 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/multicol-repaint-expected.txt View 3 chunks +46 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/resize-iframe-text-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/resize-iframe-text-expected.txt View 4 chunks +2 lines, -49 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Xianzhu
4 years ago (2016-12-02 20:56:41 UTC) #4
wkorman
lgtm
4 years ago (2016-12-02 21:07:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2543073004/1
4 years ago (2016-12-02 22:06:01 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 22:15:14 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-02 22:17:05 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3bc6c4619f272fb08cb4ca1520b4f20bf2cd9ee8
Cr-Commit-Position: refs/heads/master@{#436047}

Powered by Google App Engine
This is Rietveld 408576698