Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2543063002: MD Settings: Tolerate long words within settings-menu better. (Closed)

Created:
4 years ago by tommycli
Modified:
4 years ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Tolerate long words within settings-menu better. Before, long words (in other languages mostly), would push the iron-icon to a zero size, as well as overflow the container width. This CL prevents the iron-icon from shrinking, as well as breaks very long words into multiple lines. BUG=535630 Committed: https://crrev.com/005108ce039608fe4736289e597229f7f225bf09 Cr-Commit-Position: refs/heads/master@{#435966}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/resources/settings/settings_menu/settings_menu.html View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
tommycli
dbeam: PTAL
4 years ago (2016-12-01 23:58:15 UTC) #4
Dan Beam
lgtm
4 years ago (2016-12-02 00:14:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2543063002/1
4 years ago (2016-12-02 00:15:59 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/346401)
4 years ago (2016-12-02 01:43:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2543063002/1
4 years ago (2016-12-02 17:08:47 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 17:39:14 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-02 17:42:16 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/005108ce039608fe4736289e597229f7f225bf09
Cr-Commit-Position: refs/heads/master@{#435966}

Powered by Google App Engine
This is Rietveld 408576698